Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Add tests to LvmLogicalVolumeWatcher controller. #26

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

ViktorKram
Copy link
Contributor

@ViktorKram ViktorKram commented Feb 21, 2024

Signed-off-by: Viktor Kramarenko [email protected]

Description

Added tests to the LVMLogicalVolume controller.

Why do we need it, and what problem does it solve?

To prevent unexpected the controller's behavior.

What is the expected result?

All tests pass.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@ViktorKram ViktorKram self-assigned this Feb 21, 2024
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-tests-to-lvmlogicalvolumewatcher branch from 0c3fc62 to ac67235 Compare February 21, 2024 16:44
@ViktorKram ViktorKram added the enhancement New feature or request label Feb 21, 2024
@altermann1 altermann1 requested a review from dxavx February 26, 2024 07:25
@AleksZimin AleksZimin merged commit be6bf49 into main Feb 28, 2024
3 of 4 checks passed
@AleksZimin AleksZimin deleted the v-kramarenko-adds-tests-to-lvmlogicalvolumewatcher branch February 28, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants