Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Fix resize for thinPools #25

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

AleksZimin
Copy link
Member

@AleksZimin AleksZimin commented Feb 20, 2024

Description

This PR addresses an issue where the controller would erroneously enter the resize code path for thin pools even when resizing was not required. This unintended behavior led to errors in the resize logic, preventing the controller from proceeding to handle subsequent thin pools. As a result, the creation of new thin pools was inadvertently blocked. The fix ensures that the controller correctly bypasses the resize logic when no resizing is necessary, allowing for the seamless processing of thin pools and the unimpeded creation of new ones.

Why do we need it, and what problem does it solve?

This fix is crucial to address a flaw where the controller unnecessarily attempts to resize thin pools, leading to errors and halting further thin pool processing. This issue directly impedes the creation of new thin pools, disrupting normal storage operations. Correcting this ensures the controller only enters resize logic when needed, maintaining smooth and efficient thin pool management.

What is the expected result?

The expected outcome of this PR is the elimination of the erroneous resize behavior in the controller's handling of thin pools. Specifically, it will:

Prevent unnecessary entry into the resize logic for thin pools, thereby avoiding errors associated with unwarranted resize attempts.
Ensure that the processing of thin pools can proceed without interruption, allowing for the continuous creation of new thin pools as required.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Signed-off-by: Aleksandr Zimin <[email protected]>
@AleksZimin AleksZimin self-assigned this Feb 20, 2024
@AleksZimin AleksZimin added the bug Something isn't working label Feb 20, 2024
Signed-off-by: Aleksandr Zimin <[email protected]>
@ViktorKram ViktorKram self-requested a review February 21, 2024 13:25
@AleksZimin AleksZimin marked this pull request as ready for review February 21, 2024 13:32
@AleksZimin AleksZimin merged commit 9624445 into main Feb 21, 2024
3 checks passed
@AleksZimin AleksZimin deleted the thin-pool-change-resize branch February 21, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants