[controller] Fix resize for thinPools #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where the controller would erroneously enter the resize code path for thin pools even when resizing was not required. This unintended behavior led to errors in the resize logic, preventing the controller from proceeding to handle subsequent thin pools. As a result, the creation of new thin pools was inadvertently blocked. The fix ensures that the controller correctly bypasses the resize logic when no resizing is necessary, allowing for the seamless processing of thin pools and the unimpeded creation of new ones.
Why do we need it, and what problem does it solve?
This fix is crucial to address a flaw where the controller unnecessarily attempts to resize thin pools, leading to errors and halting further thin pool processing. This issue directly impedes the creation of new thin pools, disrupting normal storage operations. Correcting this ensures the controller only enters resize logic when needed, maintaining smooth and efficient thin pool management.
What is the expected result?
The expected outcome of this PR is the elimination of the erroneous resize behavior in the controller's handling of thin pools. Specifically, it will:
Prevent unnecessary entry into the resize logic for thin pools, thereby avoiding errors associated with unwarranted resize attempts.
Ensure that the processing of thin pools can proceed without interruption, allowing for the continuous creation of new thin pools as required.
Checklist