[controller] Fix naming bug by removing previous partUUID fix. Refactor name generation. Add test for device name. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandr Zimin <[email protected]>
dxavx
approved these changes
Feb 2, 2024
AleksZimin
changed the title
AleksZimin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a previous partUUID fix because it unintentionally broke the naming logic for block devices of type 'part'.
To improve testing and ensure accurate naming, we refactored the code to introduce a specific name generation function and added a test for this functionality.
Why do we need it, and what problem does it solve?
This PR corrects a bug introduced by a previous update that disrupted the correct naming of devices. By removing the problematic fix and adding a new test, it ensures that device names are generated correctly in the future, preventing confusion or errors in device identification.
What is the expected result?
The expected result is that the proper mechanism for naming devices will be back in place, making sure every device is named correctly. The added test will help minimize the chance of any future issues, ensuring a more dependable naming process.
Checklist