Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Ensure partUUID is used in Block Device name generation #20

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

AleksZimin
Copy link
Member

@AleksZimin AleksZimin commented Feb 1, 2024

Description

This PR corrects a recent oversight where partUUID stopped being used for naming block devices of type 'part' due to an inadvertent change. This fix reinstates the original functionality, ensuring that partUUID is once again utilized in the naming process for block devices.

Why do we need it, and what problem does it solve?

The reintroduction of partUUID for device naming corrects a critical deviation from our standard device naming. The absence of partUUID in the naming process could lead to potential identification issues and conflicts within the system. By restoring this functionality, we ensure consistent and reliable identification of block devices.

What is the expected result?

After the application of this fix, block devices of type 'part' will once again be named using their partUUID, as originally intended.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Signed-off-by: Aleksandr Zimin <[email protected]>
@AleksZimin AleksZimin requested a review from dxavx February 1, 2024 14:37
@AleksZimin AleksZimin added the bug Something isn't working label Feb 1, 2024
@AleksZimin AleksZimin self-assigned this Feb 1, 2024
@AleksZimin AleksZimin changed the title fix filtering 2 [controller] Fix part type Block Device handling and name generation Feb 1, 2024
@AleksZimin AleksZimin changed the title [controller] Fix part type Block Device handling and name generation [controller] Ensure partUUID is Used in Block Device Name Generation Feb 1, 2024
@AleksZimin AleksZimin changed the title [controller] Ensure partUUID is Used in Block Device Name Generation [controller] Ensure partUUID is used in Block Device name generation Feb 1, 2024
@AleksZimin AleksZimin marked this pull request as ready for review February 1, 2024 14:56
@AleksZimin AleksZimin merged commit 487d0fe into main Feb 1, 2024
3 of 4 checks passed
@AleksZimin AleksZimin deleted the fix-filtering-2 branch February 1, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants