Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controller] Add a LVMLogicalVolumeWatcher controller #14

Merged
merged 15 commits into from
Feb 14, 2024
Merged

[controller] Add a LVMLogicalVolumeWatcher controller #14

merged 15 commits into from
Feb 14, 2024

Conversation

ViktorKram
Copy link
Contributor

@ViktorKram ViktorKram commented Jan 17, 2024 •
edited by AleksZimin
Loading

Description

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@ViktorKram ViktorKram self-assigned this Jan 17, 2024
@ViktorKram ViktorKram marked this pull request as draft January 18, 2024 09:49
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-lvm-logical-volume-watcher branch from e2a1d82 to 55d2cc1 Compare January 18, 2024 09:50
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-logical-volume-crd-and-models branch from ed6e1c4 to 7782f14 Compare January 18, 2024 13:23
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-lvm-logical-volume-watcher branch from f6045f6 to e8e274d Compare January 19, 2024 10:33
@ViktorKram ViktorKram changed the title first-draft [controller] Add a LVMLogicalVolumeWatcher controller Jan 23, 2024
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-lvm-logical-volume-watcher branch 4 times, most recently from 017b297 to 2932997 Compare January 24, 2024 08:50
@altermann1 altermann1 added the enhancement New feature or request label Jan 31, 2024
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-lvm-logical-volume-watcher branch from 92867c9 to 5cb71be Compare February 8, 2024 18:17
@ViktorKram ViktorKram marked this pull request as ready for review February 14, 2024 07:14
ViktorKram and others added 14 commits February 14, 2024 12:47
@ViktorKram
first-draft
908d592 
Signed-off-by: viktor.kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
@ViktorKram
first version of createFunc
d9c2b16 
Signed-off-by: viktor.kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
@AleksZimin @ViktorKram
Add hostPID true and remove volume mounts
3dc111e 
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
@AleksZimin @ViktorKram
Fix indentation
ca15eaf 
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
@ViktorKram
fixed machine-id taking
2138e3a 
Signed-off-by: viktor.kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
@ViktorKram
added a LVMLogicalVolumeWatcher controller
8141f82 
Signed-off-by: viktor.kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
@ViktorKram
removed deleteFunc reconciliation
b70b249 
Signed-off-by: viktor.kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
@ViktorKram
fixed nsenter command
eb2ee10 
Signed-off-by: viktor.kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
@AleksZimin @ViktorKram
Fix nsenter args
06c5920 
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
@ViktorKram
node attachment check was moved to the events layer, finalizers attac…
eaa1498 
…hment in create event was added

Signed-off-by: viktor.kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
@ViktorKram
more info for lvcreate error
1c0402a 
Signed-off-by: viktor.kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
@ViktorKram
more info for lvcreate error
64b8bed 
Signed-off-by: viktor.kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
@ViktorKram
added stdErr out to error logs for utils commands
6acc51d 
Signed-off-by: viktor.kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
@ViktorKram
little fixes for update reconciliation
c9833ff 
Signed-off-by: Viktor Kramarenko <[email protected]>
@ViktorKram
added more logs, optimized reconciliation func runs, little refactoring
095910b 
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-lvm-logical-volume-watcher branch from aa28485 to 095910b Compare February 14, 2024 09:47
@AleksZimin AleksZimin merged commit 4bd3327 into v-kramarenko-adds-logical-volume-crd-and-models Feb 14, 2024
2 checks passed
@AleksZimin AleksZimin deleted the v-kramarenko-adds-lvm-logical-volume-watcher branch February 14, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dxavx dxavx dxavx approved these changes

@AleksZimin AleksZimin Awaiting requested review from AleksZimin

Assignees

@ViktorKram ViktorKram

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ViktorKram @dxavx @AleksZimin @altermann1