[internal] Backport: Fix access to missing finalizers, always add default finalizer #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… migration Signed-off-by: Alexandr Stefurishin <[email protected]>
duckhawk
approved these changes
Dec 10, 2024
added 2 commits
December 10, 2024 10:32
Signed-off-by: Alexandr Stefurishin <[email protected]>
Signed-off-by: Alexandr Stefurishin <[email protected]>
astef
changed the title
1 task
AleksZimin
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is backport of the fix to v0.4 branch.
Fixes
convert_bd_names_to_selector.pyto handle LVGs without finalizers.Why do we need it, and what problem does it solve?
Client upgrading from <=0.2.3 to >=0.4.0 may see errors in
convert_bd_names_to_selector.pyrelated to LVG finalizers being empty. After the current change, script will handle this case properly and add the default finalizer, if it doesn't exist.What is the expected result?
Checklist