Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow multiple filter values, fixes #7328 #7329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paulroub
Copy link

@paulroub paulroub commented Nov 14, 2024

Summary

Allows a collection filter to match one of a number of values; still allows the existing single-value syntax, as well as an array of values.

Need to manage a collection that's a combination of existing categories (rather than re-categorize all those posts).

Test plan

  • Added a unit test for the array variation, existing (non-array) tests still path.
  • Tested against my collections, with single-value, single-element-array and multiple-element-array variations all working as expected.

Checklist

Please add a x inside each checkbox:

A picture of a cute animal (not mandatory but encouraged)

rp

@paulroub paulroub marked this pull request as ready for review November 14, 2024 18:36
@paulroub paulroub requested a review from a team as a code owner November 14, 2024 18:36
@martinjagodic martinjagodic linked an issue Nov 15, 2024 that may be closed by this pull request
@martinjagodic
Copy link
Member

@paulroub, thanks for your contribution. Before we review, can you please ensure the tests are passing?

@paulroub paulroub force-pushed the add-multiple-filter-values branch from e507ff3 to ed53741 Compare November 15, 2024 17:20
@paulroub
Copy link
Author

@martinjagodic Fixed the linting issues, along the way had to tell stylelint to ignore backend.ts as it was trying to parse a cast as CSS and was not happy with the result. No actual styles in this file, of course, so that should be harmless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple possible values in a collection filter
2 participants