Specified default value behaviour #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
😂 solid plan
100%, been talking about this for a while. There's not much of a calculation, we're just using an empty string or something. Widgets can control as much as they want though - just a matter of ignoring the props. That's what the markdown widget does, and just reports the latest value back to CMS state. |
erquhart
approved these changes
Oct 24, 2019
nathankitchen
pushed a commit
to nathankitchen/netlify-cms-backend-azure
that referenced
this pull request
Feb 24, 2020
vladdu
pushed a commit
to vladdu/netlify-cms
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The docs for the select widget don't mention the widget behaviour when using object based options.
After some trial and error I think I got it figured out.
Test plan
Ask everyone involved at the office and see if my conclusion is correct.
A picture of a cute animal (not mandatory but encouraged)
Please refer to #2718
On a different/continuative note:
The widgets don't handle their own default behaviour. The control component just gets handed the current value as prop. Where in the cms is this value calculated?