Fix default value support in editor components #1511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for netlify-cms-www ready! Built with commit fe9c3fc |
|
Deploy preview for cms-demo ready! Built with commit fe9c3fc |
|
I chose to pass the plugin definition/collection to the default value function, but I don't actually need that myself, and it might be a bit too opinionated :) |
|
We should hold off on the dynamic part in this PR and just support static default values. Fields in editor components should work exactly the same as fields that are not in an editor component, which is the basis for #1406 being considered a bug. |
This was referenced Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Fix #1406 -- see the description in the issue.
Also includes a simple implementation of #1407 that's at least compatible with custom components (but there's no way to achieve dynamic default values via config.yml). I needed this myself to get my automatically issued uuids to work, but feel free to ignore that commit if a solution for #1409 is required to be a part of that feature.
- Test plan
I've tested it manually in my own application and found that the default values work with various widgets, including
hidden.- Description for the changelog
Editor components: Fix support for default field values