Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-8563 Add support for setting BatcherBuilder in Pulsar Producer #149

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

iamseki
Copy link
Contributor

@iamseki iamseki commented Jan 10, 2025

The issue described in Jira ticket has evolved into a feature request that this PR addresses.

In summary, to enable batching and improve the throughput of Pulsar's KeyShared subscription, the producer must be configured with BatcherBuilder.KEY_BASED, as pointed out in the official Pulsar documentation:

This PR introduces the ability to configure the BatcherBuilder for the Debezium Pulsar producer. For example, you can now configure it as follows:

# Sink Pulsar configuration
debezium.sink.type=pulsar
debezium.sink.pulsar.client.serviceUrl=pulsar://localhost:6650

# Sink Pulsar Producer configuration
debezium.sink.pulsar.producer.producerName=debezium_test_pulsar_batching
# New configuration for Pulsar sink
debezium.sink.pulsar.producer.batcherBuilder=KEY_BASED
...

@iamseki iamseki changed the title DBZ-8563: Add support for setting BatcherBuilder in Pulsar Producer DBZ-8563 Add support for setting BatcherBuilder in Pulsar Producer Jan 10, 2025
@iamseki
Copy link
Contributor Author

iamseki commented Jan 13, 2025

I noticed that the same test that fails in CI also fails locally but works after I update to the latest version of Debezium Core. It seems to be fixed. Can we rerun the CI?

@jpechane jpechane merged commit d23d00f into debezium:main Jan 14, 2025
2 of 3 checks passed
@jpechane
Copy link
Contributor

@iamseki Applied, thanks! Could you please a send PR to the main repo with docs update?
Test failure is unrelated.

@iamseki
Copy link
Contributor Author

iamseki commented Jan 14, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants