Skip to content

Conversation

@Gn0lee
Copy link
Collaborator

@Gn0lee Gn0lee commented Apr 7, 2025

작업 내용

  • 프로젝트 아이템 클릭시 팝업 노출
  • 이미지 url 버킷으로 수정
  • 9기 오전 추가
  • pdf url 추가

참고사항

  • DDD 프로젝트 버킷 구조 살펴보는것 추천

이미지 혹은 동영상

2025-04-07.10.29.36.mov

@Gn0lee Gn0lee requested review from Copilot and dkkim0122 April 7, 2025 13:31
@Gn0lee Gn0lee self-assigned this Apr 7, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 59 out of 59 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/app/project/_types/project.ts:16

  • [nitpick] Consider adding a space after the colon (i.e., 'popupPdf: string') to maintain consistent code formatting.
 popupPdf:string

src/app/project/_components/ProjectItemPopup.tsx:99

  • Consider adding an aria-label attribute (e.g., aria-label="Open full screen PDF") to the button for improved accessibility.
<button className="absolute top-[12px] right-[12px] desktop:p-12 netbook:p-10 tablet:p-10 mobile:p-8 rounded-[50%] bg-[rgb(12,14,15,0.48)] cursor-pointer" onClick={handleClickFullScreenButton}>

Copy link
Collaborator

@dkkim0122 dkkim0122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

버켓에 리스트 썸네일, 팝업 썸네일, 프로젝트 PPT(pdf) 다 따로 있군요. 고생하셨습니다

@Gn0lee Gn0lee merged commit e0bddc2 into develop Apr 7, 2025
1 check passed
@Gn0lee Gn0lee deleted the feature/project-click branch April 7, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants