Use pointers to proper server initializing handling

dcarrillo · Mar 20, 2023 · 8783db0 · 8783db0
1 parent e60d1ae
commit 8783db0
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 13 deletions.
diff --git a/server/quic_server.go b/server/quic_server.go
@@ -15,8 +15,8 @@ type QuicServer struct {
 	ctx       context.Context
 }
 
-func NewQuicServer(ctx context.Context, tlsServer *TLSServer) QuicServer {
-	return QuicServer{
+func NewQuicServer(ctx context.Context, tlsServer *TLSServer) *QuicServer {
+	return &QuicServer{
 		tlsServer: tlsServer,
 		ctx:       ctx,
 	}

diff --git a/server/server.go b/server/server.go
@@ -24,9 +24,9 @@ type Factory struct {
 }
 
 func Setup(ctx context.Context, handler http.Handler) *Factory {
-	var tcpServer TCPServer
-	var tlsServer TLSServer
-	var quicServer QuicServer
+	var tcpServer *TCPServer
+	var tlsServer *TLSServer
+	var quicServer *QuicServer
 
 	if setting.App.BindAddress != "" {
 		tcpServer = NewTCPServer(ctx, &handler)
@@ -35,14 +35,14 @@ func Setup(ctx context.Context, handler http.Handler) *Factory {
 	if setting.App.TLSAddress != "" {
 		tlsServer = NewTLSServer(ctx, &handler)
 		if setting.App.EnableHTTP3 {
-			quicServer = NewQuicServer(ctx, &tlsServer)
+			quicServer = NewQuicServer(ctx, tlsServer)
 		}
 	}
 
 	return &Factory{
-		tcpServer:  &tcpServer,
-		tlsServer:  &tlsServer,
-		quicServer: &quicServer,
+		tcpServer:  tcpServer,
+		tlsServer:  tlsServer,
+		quicServer: quicServer,
 	}
 }
 

diff --git a/server/tcp_server.go b/server/tcp_server.go
@@ -15,8 +15,8 @@ type TCPServer struct {
 	ctx     context.Context
 }
 
-func NewTCPServer(ctx context.Context, handler *http.Handler) TCPServer {
-	return TCPServer{
+func NewTCPServer(ctx context.Context, handler *http.Handler) *TCPServer {
+	return &TCPServer{
 		handler: handler,
 		ctx:     ctx,
 	}

diff --git a/server/tls_server.go b/server/tls_server.go
@@ -15,8 +15,8 @@ type TLSServer struct {
 	ctx     context.Context
 }
 
-func NewTLSServer(ctx context.Context, handler *http.Handler) TLSServer {
-	return TLSServer{
+func NewTLSServer(ctx context.Context, handler *http.Handler) *TLSServer {
+	return &TLSServer{
 		handler: handler,
 		ctx:     ctx,
 	}