Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register dbt-data-diff package #299

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

il-dat
Copy link
Contributor

@il-dat il-dat commented Jan 15, 2024

Description

Data-diff solution for dbt-ers with Snowflake ❄️ 🚀

Link to your package's repository: https://github.com/infinitelambda/dbt-data-diff

Checklist

This checklist is a cut down version of the best practices that we have identified as the package hub has grown. Although meeting these checklist items is not a prerequisite to being added to the Hub, we have found that packages which don't conform provide a worse user experience.

First run experience

  • The package includes a README which explains how to get started with the package and customise its behaviour
  • The README indicates which data warehouses/platforms are expected to work with this package

Customisability

  • The package uses ref or source, instead of hard-coding table references.

Packages for data transformation (delete if not relevant):

  • provide a mechanism (such as variables) to customise the location of source tables.
  • do not assume database/schema names in sources.

Dependencies

Dependencies on dbt Core

  • The package has set a supported require-dbt-version range in dbt_project.yml. Example: A package which depends on functionality added in dbt Core 1.2 should set its require-dbt-version property to [">=1.2.0", "<2.0.0"].

Dependencies on other packages defined in packages.yml:

  • Dependencies are imported from the dbt Package Hub when available, as opposed to a git installation.
  • Dependencies contain the widest possible range of supported versions, to minimise issues in dependency resolution.
  • In particular, dependencies are not pinned to a patch version unless there is a known incompatibility.

Interoperability

  • The package does not override dbt Core behaviour in such a way as to impact other dbt resources (models, tests, etc) not provided by the package.
  • The package uses the cross-database macros built into dbt Core where available, such as {{ dbt.except() }} and {{ dbt.type_string() }}.
  • The package disambiguates its resource names to avoid clashes with nodes that are likely to already exist in a project. For example, packages should not provide a model simply called users.

Versioning

  • (Required): The package's git tags validates against the regex defined in version.py
  • The package's version follows the guidance of Semantic Versioning 2.0.0. (Note in particular the recommendation for production-ready packages to be version 1.0.0 or above)

@joellabes joellabes merged commit 8b210de into dbt-labs:main Jan 16, 2024
3 checks passed
@joellabes
Copy link
Contributor

@il-dat I think that your release name is not being picked up because the regex doesn't match: https://regex101.com/r/R6Mflf/1

@il-dat il-dat deleted the feat/register-dbt-data-diff branch January 17, 2024 02:14
@il-dat
Copy link
Contributor Author

il-dat commented Jan 17, 2024

@il-dat I think that your release name is not being picked up because the regex doesn't match: https://regex101.com/r/R6Mflf/1

Thanks @joellabes for raising it!
This is the intentional naming at least for now because it is being marked as pre-release (beta 1). I will need to add some more things before closing version 1.0.0.

Just a check if it's causing any issues on your side please? If yes, I will probably go tag the official release right away.
Thanks again!

@joellabes
Copy link
Contributor

@il-dat No worries from our end! I just wanted to check you weren't expecting it to have become available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants