Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update incremental-microbatch.md #6720

Open
wants to merge 1 commit into
base: current
Choose a base branch
from
Open

Update incremental-microbatch.md #6720

wants to merge 1 commit into from
+1 −1

Conversation

czasoprzestrzenny
Copy link

What are you changing in this pull request and why?

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

@czasoprzestrzenny czasoprzestrzenny requested a review from a team as a code owner January 2, 2025 17:52
@welcome Welcome
Copy link

welcome bot commented Jan 2, 2025

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@vercel Vercel
Copy link

vercel bot commented Jan 2, 2025

@czasoprzestrzenny is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the content Improvements or additions to content label Jan 2, 2025
@runleonarun runleonarun added the new contributor Label for first-time contributors label Jan 2, 2025
@github-actions github-actions bot added the size: x-small This change will take under 3 hours to fix. label Jan 2, 2025
asarraf
asarraf approved these changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@asarraf asarraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

asarraf
asarraf reviewed Jan 4, 2025
View reviewed changes
Copy link
Contributor

@asarraf asarraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change Looks good.
However, how can we make sure that the tests / build is successful.

@asarraf
Copy link
Contributor

asarraf commented Jan 4, 2025

Please add some details in #6720 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asarraf asarraf asarraf approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@czasoprzestrzenny @asarraf @runleonarun