Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mssql-setup.md #6304

Open
wants to merge 4 commits into
base: current
Choose a base branch
from
Open

Update mssql-setup.md #6304

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8cdfd04
Update mssql-setup.md
mikaelene Oct 17, 2024
ee84ee0
Merge branch 'current' into patch-2
mirnawong1 Oct 18, 2024
82e3b09
Merge branch 'current' into patch-2
mirnawong1 Oct 21, 2024
f3011d6
Merge branch 'current' into patch-2
mikaelene Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion website/docs/docs/core/connect-data-platform/mssql-setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: "Read this guide to learn about the Microsoft SQL Server warehouse
id: "mssql-setup"
meta:
maintained_by: Community
authors: 'dbt-msft community (https://github.com/dbt-msft)'
authors: 'Mikael Ene'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
authors: 'Mikael Ene'
authors: 'Mikael Ene & [dbt-msft community](https://github.com/dbt-msft)'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dataders . Long time yes :-). I think maintained_by: explains who are maintaining the project. If the dbt-msft community are maintaining this, it should be stated there I guess? I mean, I did created this adapter and was the only maintainer for the first year. Previously my name was stated as author but was just removed one day, without any notification. It is a little weird to change author according to who currently maintains the project don't you think?

github_repo: 'dbt-msft/dbt-sqlserver'
pypi_package: 'dbt-sqlserver'
min_core_version: 'v0.14.0'
Expand Down
Loading