Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vars to state comparison caveats #6224

Closed
wants to merge 1 commit into from

Conversation

runleonarun
Copy link
Collaborator

@runleonarun runleonarun commented Oct 2, 2024

Reverts #6223

This PR adds the vars feature back to the caveat docs.

We should also:

  • Add content to the upgrade guide
  • Review and merge state:modified.vars selection method PR
  • Add this content to behavior changes page as its own section and a row in this table:

    Set the state_modified_compare_vars to True if a model uses a var or env_var in its definition. dbt will be able to identify its lineage to include the model in state:modified because the var or env_var value has changed.

@runleonarun runleonarun requested a review from a team as a code owner October 2, 2024 23:47
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 2, 2024 11:51pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Oct 2, 2024
@runleonarun runleonarun changed the title Revert "Update state-comparison-caveats.md" Add vars to state comparison caveats Oct 2, 2024
@dbeatty10
Copy link
Contributor

@runleonarun I hope it's okay with you, but I added the changes from this PR into #6222 to make it easier to us to add all the relevant docs for the state_modified_compare_vars behavior flag in one fell swoop.

I'm closing this PR in favor of #6222 accordingly. If this isn't what you want, we can totally undo the changes in the other PR and re-open this one!

@dbeatty10 dbeatty10 closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content dbt-core v1.9 Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants