Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding caveat to the false positives #6207

Merged
merged 13 commits into from
Oct 2, 2024
Merged

Adding caveat to the false positives #6207

merged 13 commits into from
Oct 2, 2024

Conversation

runleonarun
Copy link
Collaborator

Closes #6197

What are you changing in this pull request and why?

Adjusting false positives section to account for new flag that reduces false positives by not recognizing jinja code changes as a state:modified

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@runleonarun runleonarun requested a review from a team as a code owner October 2, 2024 00:52
@vercel Vercel
Copy link

vercel bot commented Oct 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 2, 2024 10:54pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. labels Oct 2, 2024
@graciegoheen
Copy link
Collaborator

Can we also add a callout to the vars section?
Screenshot 2024-10-01 at 10 50 56 PM

The behavior change flag state_modified_compare_vars, also versioned 1.9+

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Oct 2, 2024
@runleonarun
Copy link
Collaborator Author

Can we also add a callout to the vars section? Screenshot 2024-10-01 at 10 50 56 PM

The behavior change flag state_modified_compare_vars, also versioned 1.9+

Applied this information in this commit

graciegoheen
graciegoheen reviewed Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@graciegoheen graciegoheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few small comments! thanks, this is tricky stuff :)

website/docs/reference/node-selection/state-comparison-caveats.md Outdated Show resolved Hide resolved
website/docs/reference/node-selection/state-comparison-caveats.md Outdated Show resolved Hide resolved
website/docs/reference/node-selection/state-comparison-caveats.md Outdated Show resolved Hide resolved
website/docs/reference/node-selection/state-comparison-caveats.md Outdated Show resolved Hide resolved
website/docs/reference/node-selection/state-comparison-caveats.md Outdated Show resolved Hide resolved
@graciegoheen
Copy link
Collaborator

Let's add a release note for these as well!

graciegoheen
graciegoheen approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@graciegoheen graciegoheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@runleonarun runleonarun merged commit 8c148d0 into current Oct 2, 2024
6 checks passed
@runleonarun runleonarun deleted the fixing-false-pos branch October 2, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graciegoheen graciegoheen graciegoheen approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] Update "Caveats to state comparison"
3 participants
@runleonarun @graciegoheen @mirnawong1