Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nfiann-qs-for-dbtcore-duckdb #5783

Open
wants to merge 171 commits into
base: current
Choose a base branch
from

Conversation

nataliefiann
Copy link
Contributor

@nataliefiann nataliefiann commented Jul 15, 2024

What are you changing in this pull request and why?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@nataliefiann nataliefiann requested a review from a team as a code owner July 15, 2024 13:42
Copy link

vercel bot commented Jul 15, 2024

Deployment failed with the following error:

Redirect at index 0 has invalid `source` pattern "/guides/codespace?step=4".

Learn More: https://vercel.link/invalid-route-source-pattern

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: large This change will more than a week to address and might require more than one person labels Jul 15, 2024
@nataliefiann
Copy link
Contributor Author

My vercel deploy failed. I think this may be because I redirected:
/guides/codespace?step=4 to: /guides/DuckDB?step=5
If someone wouldn't mind talking to me about this.

Kind Regards

@nghi-ly
Copy link
Contributor

nghi-ly commented Jul 16, 2024

@nataliefiann : i tried troubleshooting this build error. something wonky seems to be going on. there are no build errors when i run npm run build locally. i've asked the web team to see if they can help. please see slack convo

Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 12, 2024 5:39pm

@nghi-ly nghi-ly self-requested a review July 16, 2024 23:31
- [Schedule a job](/guides/manual-install?step=5)


### Prerequisites
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would recommend turnign this to an h2?


<TabItem value="web" label="Web browser">

1. Go to the `jaffle-shop-template` [repository](https://github.com/dbt-labs/jaffle-shop-template) after you log in to your GitHub account.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the right template we want to share? it looks like its archived? should this be used instead?
Screenshot 2024-10-14 at 15 54 38

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the link is incorrect, then do the steps in the 'web browser' tab need changing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @nataliefiann , i noticed you changed the link but i would recommend triple checking this with the sme


1. Go to the `jaffle-shop-template` [repository](https://github.com/dbt-labs/jaffle-shop-template) after you log in to your GitHub account.
1. Click **Use this template** at the top of the page and choose **Create new repository**.
1. Click **Create repository from template** when you’re done setting the options for your new repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the instructions here updated? it says 'codespace' environment but this is for duckdb?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Mirna, I'll shoot a message across to Anders about this


<TabItem value="local" label="Local">

1. First, [clone](https://git-scm.com/docs/git-clone/en) the Jaffle Shop git repository by running the following command in your terminal:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this link returns a 404

- [dbt docs serve](/reference/commands/cmd-docs#dbt-docs-serve) &mdash; starts a webserver on port 8080 to serve your documentation locally and opens the documentation site in your default browser.

For complete details, refer to the [dbt command reference](/reference/dbt-commands).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be beneficial for both tabs (local and web browser) to add a screenshot or code snippet of what successful output looks like.

Copy link
Contributor

@mirnawong1 mirnawong1 Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. a shorter version of this (its too long)

(venv) ➜  jaffle_shop_duckdb git:(duckdb) dbt build
15:10:12  Running with dbt=1.8.1
15:10:13  Registered adapter: duckdb=1.8.1
15:10:13  Found 5 models, 3 seeds, 20 data tests, 416 macros
15:10:13  
15:10:14  Concurrency: 24 threads (target='dev')
15:10:14  
15:10:14  1 of 28 START seed file main.raw_customers ..................................... [RUN]
15:10:14  2 of 28 START seed file main.raw_orders ........................................ [RUN]
15:10:14  3 of 28 START seed file main.raw_payments ...................................... [RUN]
15:10:14  1 of 28 OK loaded seed file main.raw_customers ................................. [INSERT 100 in 0.19s]
15:10:14  2 of 28 OK loaded seed file main.raw_orders .................................... [INSERT 99 in 0.20s]
15:10:14  4 of 28 START sql view model main.stg_customers ................................ [RUN]
15:10:14  3 of 28 OK loaded seed file main.raw_payments .................................. [INSERT 113 in 0.21s]
15:10:14  5 of 28 START sql view model main.stg_orders ................................... [RUN]
15:10:14  6 of 28 START sql view model main.stg_payments ................................. [RUN]
15:10:14  4 of 28 OK created sql view model main.stg_customers ........................... [OK in 0.16s]
15:10:14  5 of 28 OK created sql view model main.stg_orders .............................. [OK in 0.15s]
15:10:14  7 of 28 START test not_null_stg_customers_customer_id .......................... [RUN]
15:10:14  8 of 28 START test unique_stg_customers_customer_id ............................ [RUN]
15:10:14  6 of 28 OK created sql view model main.stg_payments ............................ [OK in 0.16s]
15:10:14  9 of 28 START test accepted_values_stg_orders_status__placed__shipped__completed__return_pending__returned  [RUN]
15:10:14  10 of 28 START test not_null_stg_orders_order_id ............................... [RUN]
15:10:14  11 of 28 START test unique_stg_orders_order_id ................................. [RUN]
15:10:14  12 of 28 START test accepted_values_stg_payments_payment_method__credit_card__coupon__bank_transfer__gift_card  [RUN]
15:10:14  13 of 28 START test not_null_stg_payments_payment_id ........................... [RUN]
15:10:14  14 of 28 START test unique_stg_payments_payment_id ............................. [RUN]
15:10:14  7 of 28 PASS not_null_stg_customers_customer_id ................................ [PASS in 0.25s]
15:10:14  10 of 28 PASS not_null_stg_orders_order_id ..................................... [PASS in 0.22s]
15:10:14  11 of 28 PASS unique_stg_orders_order_id ....................................... [PASS in 0.22s]
15:10:14  8 of 28 PASS unique_stg_customers_customer_id .................................. [PASS in 0.26s]
15:10:14  9 of 28 PASS accepted_values_stg_orders_status__placed__shipped__completed__return_pending__returned  [PASS in 0.23s]
15:10:14  13 of 28 PASS not_null_stg_payments_payment_id ................................. [PASS in 0.22s]
15:10:14  12 of 28 PASS accepted_values_stg_payments_payment_method__credit_card__coupon__bank_transfer__gift_card  [PASS in 0.22s]
15:10:14  14 of 28 PASS unique_stg_payments_payment_id ................................... [PASS in 0.22s]
15:10:14  15 of 28 START sql table model main.customers .................................. [RUN]
15:10:14  16 of 28 START sql table model main.orders ..................................... [RUN]
15:10:14  16 of 28 OK created sql table model main.orders ................................ [OK in 0.13s]
15:10:14  17 of 28 START test accepted_values_orders_status__placed__shipped__completed__return_pending__returned  [RUN]
15:10:14  15 of 28 OK created sql table model main.customers ............................. [OK in 0.15s]
15:10:14  18 of 28 START test not_null_orders_amount ..................................... [RUN]
15:10:14  19 of 28 START test not_null_orders_bank_transfer_amount ....................... [RUN]
15:10:14  20 of 28 START test not_null_orders_coupon_amount .............................. [RUN]
15:10:14  21 of 28 START test not_null_orders_credit_card_amount ......................... [RUN]
15:10:14  22 of 28 START test not_null_orders_customer_id ................................ [RUN]
15:10:14  23 of 28 START test not_null_orders_gift_card_amount ........................... [RUN]
15:10:14  24 of 28 START test not_null_orders_order_id ................................... [RUN]
15:10:14  25 of 28 START test unique_orders_order_id ..................................... [RUN]
15:10:15  26 of 28 START test not_null_customers_customer_id ............................. [RUN]
15:10:15  27 of 28 START test relationships_orders_customer_id__customer_id__ref_customers_  [RUN]
15:10:15  28 of 28 START test unique_customers_customer_id ............................... [RUN]
15:10:15  17 of 28 PASS accepted_values_orders_status__placed__shipped__completed__return_pending__returned  [PASS in 0.32s]
15:10:15  19 of 28 PASS not_null_orders_bank_transfer_amount ............................. [PASS in 0.32s]
15:10:15  18 of 28 PASS not_null_orders_amount ........................................... [PASS in 0.32s]
15:10:15  21 of 28 PASS not_null_orders_credit_card_amount ............................... [PASS in 0.34s]
15:10:15  22 of 28 PASS not_null_orders_customer_id ...................................... [PASS in 0.34s]
15:10:15  20 of 28 PASS not_null_orders_coupon_amount .................................... [PASS in 0.34s]
15:10:15  24 of 28 PASS not_null_orders_order_id ......................................... [PASS in 0.34s]
15:10:15  23 of 28 PASS not_null_orders_gift_card_amount ................................. [PASS in 0.35s]
15:10:15  25 of 28 PASS unique_orders_order_id ........................................... [PASS in 0.35s]
15:10:15  26 of 28 PASS not_null_customers_customer_id ................................... [PASS in 0.31s]
15:10:15  28 of 28 PASS unique_customers_customer_id ..................................... [PASS in 0.31s]
15:10:15  27 of 28 PASS relationships_orders_customer_id__customer_id__ref_customers_ .... [PASS in 0.32s]
15:10:15  
15:10:15  Finished running 3 seeds, 3 view models, 20 data tests, 2 table models in 0 hours 0 minutes and 1.52 seconds (1.52s).
15:10:15  
15:10:15  Completed successfully
15:10:15  
15:10:15  Done. PASS=28 WARN=0 ERROR=0 SKIP=0 TOTAL=28

@@ -73,7 +73,7 @@ Learn more about [dbt Cloud features](/docs/cloud/about-cloud/dbt-cloud-feature
Refer to the following quickstarts to get started with dbt Core:

- [dbt Core from a manual install](/guides/manual-install) to learn how to install dbt Core and set up a project.
- [dbt Core using GitHub Codespace](/guides/codespace?step=1) to learn how to create a codespace and execute the `dbt build` command.
- [dbt Core using DuckDB](/guides/duckdb?step=1) to learn how to connect to DuckDB and execute the `dbt build` command.
Copy link
Contributor

@dataders dataders Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [dbt Core using DuckDB](/guides/duckdb?step=1) to learn how to connect to DuckDB and execute the `dbt build` command.
- [dbt Core using DuckDB](/guides/duckdb?step=1) to learn how to connect to DuckDB and execute the `dbt build` command.
- [dbt Core using DuckDB (Github Codespace)](/guides/codespace?step=1) to use a pre-configued GitHub codespaces that streamlines the above quickestart's setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content guides Knowledge best suited for Guides size: large This change will more than a week to address and might require more than one person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants