Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt-postgres 'microbatch' strategy #146

Merged
merged 7 commits into from
Sep 12, 2024
Merged

dbt-postgres 'microbatch' strategy #146

merged 7 commits into from
Sep 12, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Sep 6, 2024

resolves #149
docs dbt-labs/docs.getdbt.com/#

Problem

As part of dbt-labs/dbt-core#10624, dbt-postgres needs to implement a default microbatch strategy.

Solution

Although it is not write-optimized for partitioned data, we will use merge under-the-hood in dbt-postgres for now, as dbt-postgres does not yet support partitioning.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-postgres contributing guide.

@MichelleArk MichelleArk changed the title for testing: dbt-postgres 'microbatch' strategy dbt-postgres 'microbatch' strategy Sep 10, 2024
pyproject.toml Outdated Show resolved Hide resolved
@MichelleArk MichelleArk marked this pull request as ready for review September 11, 2024 19:13
@MichelleArk MichelleArk requested a review from a team as a code owner September 11, 2024 19:13
Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval conditional on repointing to main of course.

@MichelleArk
Copy link
Contributor Author

Confirmed the failing tests are expected on tests/functional/adapter/test_incremental_microbatch.py::TestPostgresMicrobatch::test_run_with_event_time. Going to go ahead and merge on failing CI here as this will just be intermittent until dbt-labs/dbt-core#10624 is merged.

@MichelleArk MichelleArk enabled auto-merge (squash) September 12, 2024 20:18
@MichelleArk MichelleArk merged commit a676c4e into main Sep 12, 2024
18 of 23 checks passed
@MichelleArk MichelleArk deleted the poc-microbatch-merge branch September 12, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dbt-postgres] Microbatch strategy implementation: merge
3 participants