Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add child_map, parent_map, group_map to Manifest class #11030

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Nov 21, 2024

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@gshank gshank requested a review from a team as a code owner November 21, 2024 21:57
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.10%. Comparing base (a42303c) to head (77efbeb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11030      +/-   ##
==========================================
- Coverage   89.15%   89.10%   -0.05%     
==========================================
  Files         183      183              
  Lines       23764    23767       +3     
==========================================
- Hits        21186    21177       -9     
- Misses       2578     2590      +12     
Flag Coverage Δ
integration 86.41% <100.00%> (-0.12%) ⬇️
unit 62.17% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.17% <100.00%> (+<0.01%) ⬆️
Integration Tests 86.41% <100.00%> (-0.12%) ⬇️
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant