Housekeeping for the gem: require Ruby3, updates to newest Rubocop with rubocop-rake and rubocop-rspec plugins #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonneutert
force-pushed
the
implement-rubocop-plugins
branch
2 times, most recently
from
04182fc to
d06a1f6
Compare
simonneutert
force-pushed
the
implement-rubocop-plugins
branch
from
d06a1f6 to
3528260
Compare
simonneutert
force-pushed
the
implement-rubocop-plugins
branch
from
3528260 to
e729f54
Compare
simonneutert
force-pushed
the
implement-rubocop-plugins
branch
from
078f84a to
d848560
Compare
|
I would not increment the version to 3.0.0 here because there's no API changes. If .gemspec is clear that Ruby >= 3.0 is required rubygems is just not going to let users on 2.7 upgrade to the new version anyway. |
dblock
reviewed
Sep 17, 2024
simonneutert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I intend to lay the groundwork for a 3.0 release of the gem.
As this PR will drop support for Ruby 2.x a major version bump is needed.
This PR does
>= 3.0.0rubocop-rakeandrubocop-rspecand fixes what was offcloses #70