fix: snapshots failing because of wrong mysql colum quoting (#171)

* fix: snapshots failing because of wrong mysql colum quoting * adding create columns for three DBs * update changelogs * Fix create_columns macro invocation to be more general. --------- Co-authored-by: Matthew Wallace <[email protected]>
dbeatty10 · May 27, 2024 · e609d4d · e609d4d
1 parent ddac484
commit e609d4d
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 - Support dbt v1.5 ([#145](https://github.com/dbeatty10/dbt-mysql/issues/145))
 - Support connecting via UNIX sockets ([#164](https://github.com/dbeatty10/dbt-mysql/issues/164))
 - Support Black & MyPy pre-commit hooks ([#138](https://github.com/dbeatty10/dbt-mysql/issues/138))
+- Support dbt snapshots if table DDL is evolving ([#171](https://github.com/dbeatty10/dbt-mysql/pull/171))
 
 ### Fixes
 - Fix incremental composite keys ([#144](https://github.com/dbeatty10/dbt-mysql/issues/144))

diff --git a/dbt/include/mariadb/macros/materializations/snapshot/snapshot.sql b/dbt/include/mariadb/macros/materializations/snapshot/snapshot.sql
@@ -1,3 +1,14 @@
+{#
+ Add new columns to the table if applicable
+#}
+
+{% macro mariadb__create_columns(relation, columns) %}
+ {% for column in columns %}
+ {% call statement() %}
+ alter table {{ relation }} add column {{ column.quoted() }} {{ column.data_type }};
+ {% endcall %}
+ {% endfor %}
+{% endmacro %}
 
 {% macro mariadb__snapshot_string_as_time(timestamp) -%}
  {%- set result = "str_to_date('" ~ timestamp ~ "', '%Y-%m-%d %T')" -%}

diff --git a/dbt/include/mysql/macros/materializations/snapshot/snapshot.sql b/dbt/include/mysql/macros/materializations/snapshot/snapshot.sql
@@ -1,3 +1,14 @@
+{#
+ Add new columns to the table if applicable
+#}
+
+{% macro mysql__create_columns(relation, columns) %}
+ {% for column in columns %}
+ {% call statement() %}
+ alter table {{ relation }} add column {{ column.quoted() }} {{ column.data_type }};
+ {% endcall %}
+ {% endfor %}
+{% endmacro %}
 
 {% macro mysql__snapshot_string_as_time(timestamp) -%}
  {%- set result = "str_to_date('" ~ timestamp ~ "', '%Y-%m-%d %T')" -%}

diff --git a/dbt/include/mysql5/macros/materializations/snapshot/snapshot.sql b/dbt/include/mysql5/macros/materializations/snapshot/snapshot.sql
@@ -1,3 +1,14 @@
+{#
+ Add new columns to the table if applicable
+#}
+
+{% macro mysql5__create_columns(relation, columns) %}
+ {% for column in columns %}
+ {% call statement() %}
+ alter table {{ relation }} add column {{ column.quoted() }} {{ column.data_type }};
+ {% endcall %}
+ {% endfor %}
+{% endmacro %}
 
 {% macro mysql5__snapshot_string_as_time(timestamp) -%}
  {%- set result = "str_to_date('" ~ timestamp ~ "', '%Y-%m-%d %T')" -%}