-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial commit #1074
Open
annsch
wants to merge
3
commits into
main
Choose a base branch
from
angular-17-example-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
initial commit #1074
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # Editor configuration, see https://editorconfig.org | ||
| root = true | ||
|
|
||
| [*] | ||
| charset = utf-8 | ||
| indent_style = space | ||
| indent_size = 2 | ||
| insert_final_newline = true | ||
| trim_trailing_whitespace = true | ||
|
|
||
| [*.ts] | ||
| quote_type = single | ||
|
|
||
| [*.md] | ||
| max_line_length = off | ||
| trim_trailing_whitespace = false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| # See http://help.github.com/ignore-files/ for more about ignoring files. | ||
|
|
||
| # Compiled output | ||
| /dist | ||
| /tmp | ||
| /out-tsc | ||
| /bazel-out | ||
|
|
||
| # Node | ||
| /node_modules | ||
| npm-debug.log | ||
| yarn-error.log | ||
|
|
||
| # IDEs and editors | ||
| .idea/ | ||
| .project | ||
| .classpath | ||
| .c9/ | ||
| *.launch | ||
| .settings/ | ||
| *.sublime-workspace | ||
|
|
||
| # Visual Studio Code | ||
| .vscode/* | ||
| !.vscode/settings.json | ||
| !.vscode/tasks.json | ||
| !.vscode/launch.json | ||
| !.vscode/extensions.json | ||
| .history/* | ||
|
|
||
| # Miscellaneous | ||
| /.angular/cache | ||
| .sass-cache/ | ||
| /connect.lock | ||
| /coverage | ||
| /libpeerconnection.log | ||
| testem.log | ||
| /typings | ||
|
|
||
| # System files | ||
| .DS_Store | ||
| Thumbs.db |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=827846 | ||
| "recommendations": ["angular.ng-template"] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "name": "ng serve", | ||
| "type": "chrome", | ||
| "request": "launch", | ||
| "preLaunchTask": "npm: start", | ||
| "url": "http://localhost:4200/" | ||
| }, | ||
| { | ||
| "name": "ng test", | ||
| "type": "chrome", | ||
| "request": "launch", | ||
| "preLaunchTask": "npm: test", | ||
| "url": "http://localhost:9876/debug.html" | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?LinkId=733558 | ||
| "version": "2.0.0", | ||
| "tasks": [ | ||
| { | ||
| "type": "npm", | ||
| "script": "start", | ||
| "isBackground": true, | ||
| "problemMatcher": { | ||
| "owner": "typescript", | ||
| "pattern": "$tsc", | ||
| "background": { | ||
| "activeOnStart": true, | ||
| "beginsPattern": { | ||
| "regexp": "(.*?)" | ||
| }, | ||
| "endsPattern": { | ||
| "regexp": "bundle generation complete" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "type": "npm", | ||
| "script": "test", | ||
| "isBackground": true, | ||
| "problemMatcher": { | ||
| "owner": "typescript", | ||
| "pattern": "$tsc", | ||
| "background": { | ||
| "activeOnStart": true, | ||
| "beginsPattern": { | ||
| "regexp": "(.*?)" | ||
| }, | ||
| "endsPattern": { | ||
| "regexp": "bundle generation complete" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Found issues | ||
|
|
||
| ## Docs | ||
|
|
||
| - style.css: rename @import "..." to @import "... .css" | ||
| - Watch mode: [ERROR] Two output files share the same path but have different contents: media/db-ux.woff2 | ||
| --> fix this with "development": { | ||
| "outputHashing": "media" | ||
| }, https://github.com/angular/angular-cli/issues/26347 | ||
| - README.md: rename primary -> brand | ||
| - README.md: rename DBInput -> db-input | ||
| - README.md: DBButton -> db-button | ||
| - no auto-correction for component props | ||
| - missing docs for navigation directives | ||
|
|
||
| ## Bugs | ||
|
|
||
| - floating label: animation is laggy | ||
| - db-main-navigation: directive import leads to error: | ||
| `An unhandled exception occurred: Missing "./components/header/ActionBar.directive" specifier in "@db-ui/ngx-components" package | ||
| See "/private/var/folders/t6/wg_h_yhn4bb6_7g9yn30qqmw0000gn/T/ng-nNRT5n/angular-errors.log" for further details.` | ||
| - db-brand: image not found / https://github.com/db-ui/mono/issues/2413 | ||
|
|
||
| ## Questions | ||
|
|
||
| - db-brand: <db-brand>db-ui component test</db-brand> is empty -> has to be used with <db-brand brand> .... why? | ||
| - why can't <db-header> be used with any child, e.g. <db-header>bla bla</db-header>? | ||
|
|
||
| # Other | ||
|
|
||
| - docs from MainNavigation and MainNavigation Item are separated |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| { | ||
| "$schema": "./node_modules/@angular/cli/lib/config/schema.json", | ||
| "version": 1, | ||
| "newProjectRoot": "projects", | ||
| "projects": { | ||
| "angular-17": { | ||
| "projectType": "application", | ||
| "schematics": {}, | ||
| "root": "", | ||
| "sourceRoot": "src", | ||
| "prefix": "app", | ||
| "architect": { | ||
| "build": { | ||
| "builder": "@angular-devkit/build-angular:application", | ||
| "options": { | ||
| "outputPath": "dist/angular-17", | ||
| "index": "src/index.html", | ||
| "browser": "src/main.ts", | ||
| "polyfills": ["zone.js"], | ||
| "tsConfig": "tsconfig.app.json", | ||
| "assets": ["src/favicon.ico", "src/assets"], | ||
| "styles": ["src/styles.css"], | ||
| "scripts": [] | ||
| }, | ||
| "configurations": { | ||
| "production": { | ||
| "budgets": [ | ||
| { | ||
| "type": "initial", | ||
| "maximumWarning": "500kb", | ||
| "maximumError": "1mb" | ||
| }, | ||
| { | ||
| "type": "anyComponentStyle", | ||
| "maximumWarning": "2kb", | ||
| "maximumError": "4kb" | ||
| } | ||
| ], | ||
| "outputHashing": "all" | ||
| }, | ||
| "development": { | ||
| "optimization": false, | ||
| "extractLicenses": false, | ||
| "sourceMap": true, | ||
| "outputHashing": "media" | ||
| } | ||
| }, | ||
| "defaultConfiguration": "production" | ||
| }, | ||
| "serve": { | ||
| "builder": "@angular-devkit/build-angular:dev-server", | ||
| "configurations": { | ||
| "production": { | ||
| "buildTarget": "angular-17:build:production" | ||
| }, | ||
| "development": { | ||
| "buildTarget": "angular-17:build:development" | ||
| } | ||
| }, | ||
| "defaultConfiguration": "development" | ||
| }, | ||
| "extract-i18n": { | ||
| "builder": "@angular-devkit/build-angular:extract-i18n", | ||
| "options": { | ||
| "buildTarget": "angular-17:build" | ||
| } | ||
| }, | ||
| "test": { | ||
| "builder": "@angular-devkit/build-angular:karma", | ||
| "options": { | ||
| "polyfills": ["zone.js", "zone.js/testing"], | ||
| "tsConfig": "tsconfig.spec.json", | ||
| "assets": ["src/favicon.ico", "src/assets"], | ||
| "styles": ["src/styles.css"], | ||
| "scripts": [] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@annsch are those comments provided like this through the toolset? In general, this would make the JSON invalid, so migrating to another structure would enable both a valid JSON as well as integrating this comment (except that if this file expects a specific schema).