Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(icons): extracted icons mixin related files #527

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

refactor(icons): extracted icons mixin related files #527

wants to merge 5 commits into from

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Aug 1, 2023

Resolves #526

@mfranzke mfranzke added documentation Improvements or additions to documentation improvement labels Aug 1, 2023
@mfranzke mfranzke added this to the Release 2.x milestone Aug 1, 2023
@mfranzke mfranzke self-assigned this Aug 1, 2023
@mfranzke mfranzke linked an issue Aug 1, 2023 that may be closed by this pull request
Provide a general icon SCSS file #526
Open
@mfranzke mfranzke enabled auto-merge (squash) August 1, 2023 18:04
@mfranzke mfranzke marked this pull request as draft August 1, 2023 18:04
auto-merge was automatically disabled August 1, 2023 18:04

Pull request was converted to draft

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

🔭🐙🐈 Test this branch here: https://db-ui.github.io/core/review/526-provide-a-general-icon-scss-file

@github-actions github-actions bot added patterns and removed documentation Improvements or additions to documentation labels Aug 1, 2023
@mfranzke mfranzke marked this pull request as ready for review August 2, 2023 06:46
@nmerget
Copy link
Member

nmerget commented Aug 2, 2023

Wouldn't it be better if we change @import to @use so we could keep the correct dependencies for icons in every file and reduce the amount of imports as well?

@mfranzke
Copy link
Member Author

mfranzke commented Aug 2, 2023 •
edited
Loading

Wouldn't it be better if we change @import to @use so we could keep the correct dependencies for icons in every file and reduce the amount of imports as well?

I'll give it a try.

@mfranzke mfranzke marked this pull request as draft August 2, 2023 07:34
@mfranzke mfranzke changed the title refactor(icons): extracted icons mixin related files #526 refactor(icons): extracted icons mixin related files Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch will be requested when the pull request is marked ready for review bruno-sch is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mfranzke mfranzke

Labels
improvement patterns
Projects
None yet
Milestone
Guidelines v2
Development

Successfully merging this pull request may close these issues.

Provide a general icon SCSS file
2 participants
@mfranzke @nmerget