Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed brand fonts from the repositories #1032

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+16 −11
Draft

refactor: removed brand fonts from the repositories #1032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac1faa6
refactor: removed brand fonts from the repositories
mfranzke Dec 6, 2024
4d35252
Update package.json
mfranzke Dec 6, 2024
68cb2a6
Update enterprise.patternlab-config.json
mfranzke Dec 6, 2024
faef991
feat: added entry for migration guide
mfranzke Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/migrationGuide.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ As with every release you're recommended to do a visual regression testing for y

Especially the following aspects have changed through the various different releases and would need your review and probably adaptions within your code base.

== DB UI Core 4.0.0 Migration Guide

=== Removed brand fonts

We needed to remove the brand fonts from our link:https://www.npmjs.com/package/@db-ui/base[`@db-ui/base`] node package. Please follow the guidelines within link:https://marketingportal.extranet.deutschebahn.com/marketingportal/Design-Anwendungen/db-ux-design-system/version-2/foundation/Typografie[DB Marketingportal] (DB internal) on how to retrieve it as an Inner Source package or download the package with the font files from there (DB external).

== DB UI Core 3.0.0 Migration Guide

=== Chip
Expand Down
2 changes: 0 additions & 2 deletions enterprise.patternlab-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
},
"js": "./source/js",
"images": "./source/images",
"fonts": "./node_modules/@db-ui/base/build/assets/fonts",
"css": "./source/css",
"icons": "./node_modules/@db-ui/base/build/assets/icons",
"samples": "./source/samples",
Expand All @@ -71,7 +70,6 @@
"styleguide": "out/styleguide/",
"js": "out/js",
"images": "out/images",
"fonts": "out/fonts",
"css": "out/css",
"icons": "out/icons",
"samples": "out/samples",
Expand Down
15 changes: 8 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"js-deploy": "npm run js-build && cpr source/js dist/js -d",
"js-build": "babel source/**/*.plugin.js --minified --out-file source/js/plugins.min.js --source-maps",
"js-watch": "npm run js-build -- --watch",
"copy-assets": "cpr node_modules/@db-ui/base/build/assets/icons dist/icons -d && cpr node_modules/@db-ui/base/build/assets/fonts dist/fonts --filter=\"^(.*[/]sources[/]).*$\" -d | cpr source/images dist/images -d | cpr source/favicon.ico dist/favicon.ico -o | cpr source/robots.txt dist/robots.txt -o | cpr source/site.webmanifest dist/site.webmanifest -o",
"copy-assets": "cpr node_modules/@db-ui/base/build/assets/icons dist/icons -d | cpr source/images dist/images -d | cpr source/favicon.ico dist/favicon.ico -o | cpr source/robots.txt dist/robots.txt -o | cpr source/site.webmanifest dist/site.webmanifest -o",
"copy-scss-sources": "cpr source/_patterns/ sources/_patterns/ --filter=\"^(?!.*[.](scss|sass)$).*$\" -d | cpr source/css/ sources/css/ --filter=\"^(?!.*[.](scss|sass)$).*$\" -d",
"clean": "git clean -dfx --exclude=.env",
"build": "rimraf dist && npm-run-all css-deploy js-deploy pl:build:* --parallel copy-assets copy-scss-sources",
Expand All @@ -58,7 +58,7 @@
"license": "Apache-2.0",
"dependencies": {
"@csstools/normalize.css": "^12.1.1",
"@db-ui/base": "^0.28.4"
"@db-ui/base": "^0.29.0-1"
},
"devDependencies": {
"@babel/cli": "^7.25.9",
Expand Down
Loading