Skip to content

Commit

Permalink
refactor: moved basic styles to base
Browse files Browse the repository at this point in the history
  • Loading branch information
annsch committed Jan 13, 2023
1 parent e826142 commit 014c13d
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 114 deletions.
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"license": "Apache-2.0",
"dependencies": {
"@csstools/normalize.css": "^12.0.0",
"@db-ui/base": "2.0.0-20-58c8a10"
"@db-ui/base": "2.0.0-21-06f1b12"
},
"devDependencies": {
"@babel/cli": "^7.19.3",
Expand Down
31 changes: 0 additions & 31 deletions source/_patterns/00-base/_init.global.scss
Original file line number Diff line number Diff line change
@@ -1,17 +1,6 @@
@use "@db-ui/base/build/scss/variables" as *;
@use "@db-ui/base/build/scss/helpers/functions" as *;

// *! this is an opionionated (especially based on "enhancing" normalize.css) version of minireset.css v0.0.4 | MIT License | github.com/jgthms/minireset.css
html,
body {
margin: 0;
padding: 0;
}

body {
min-height: 100vh;
}

// adapted from https://github.com/jgthms/bulma/blob/0.7.5/sass/base/generic.sass
html {
background-color: #fdfdfd; // TODO: This would need to get replaced by the correct (semantic) color
Expand Down Expand Up @@ -48,16 +37,6 @@ body {
line-height: 1.5;
}

// Inline
a {
// TODO: Move to DB UI Base
color: inherit;

strong {
color: currentColor;
}
}

code {
background-color: #f5f5f5;
color: darken($db-colors-primary-enabled, 2%);
Expand All @@ -74,20 +53,10 @@ hr {
margin: 1.5rem 0;
}

img {
height: auto;
max-width: 100%;
}

small {
font-size: to-em($pxValue: 14);
}

// Block
fieldset {
border: none;
}

pre {
background-color: #f5f5f5;
color: #282d37;
Expand Down
73 changes: 0 additions & 73 deletions source/_patterns/00-base/_init.scss

This file was deleted.

1 change: 0 additions & 1 deletion source/css/db-ui-core.general.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@

@import "@csstools/normalize.css/normalize";
@import "db-ui-core.variables";
@import "../_patterns/00-base/init";
1 change: 0 additions & 1 deletion source/css/enterprise/db-ui-core.scss
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ $partial: false;
@use "@db-ui/base/build/scss/color-placeholder" as *;

@use "../../_patterns/00-base/init.global" as *;
@use "../../_patterns/00-base/init" as *;

// Importing helpers
@use "@db-ui/base/build/scss/helpers/functions" as *;
Expand Down

0 comments on commit 014c13d

Please sign in to comment.