Feat/api keys updates #3347
Open
Feat/api keys updates #3347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpavlini
force-pushed
the
feat/api-keys-updates
branch
from
e6b1fb0 to
12c38b6
Compare
rpavlini
force-pushed
the
feat/api-keys-updates
branch
from
bf55ae4 to
1bbf9c8
Compare
Tpuljak
requested changes
Jan 20, 2026
Member
There was a problem hiding this comment.
I don't like that the toggled (active) state is exactly the same style as the hover state.
On the screenshot above, I have 2 perms active and one is hovered. Tell me which is which 😄
| <Alert variant="info"> | ||
| <InfoIcon /> | ||
| <AlertTitle>Sandboxes Access</AlertTitle> | ||
| <AlertDescription>This key grants access to the Sandboxes resource.</AlertDescription> |
Member
There was a problem hiding this comment.
Suggested change
| <AlertDescription>This key grants access to the Sandboxes resource.</AlertDescription> | |
| <AlertDescription>This key grants read and write to the Sandboxes resource.</AlertDescription> |
I suggest being explicit here because "grants access" might be interpreted as read-only
Signed-off-by: rpavlini <rpavlinic@daytona.io>
Signed-off-by: rpavlini <rpavlinic@daytona.io>
Signed-off-by: rpavlini <rpavlinic@daytona.io>
Signed-off-by: rpavlini <rpavlinic@daytona.io>
Signed-off-by: rpavlini <rpavlinic@daytona.io>
Signed-off-by: rpavlini <rpavlinic@daytona.io>
Signed-off-by: rpavlini <rpavlinic@daytona.io>
Signed-off-by: rpavlini <rpavlinic@daytona.io>
Signed-off-by: rpavlini <rpavlinic@daytona.io>
rpavlini
force-pushed
the
feat/api-keys-updates
branch
from
1bbf9c8 to
97b91c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation
Related Issue(s)
closes #2973
closes DAS-12
closes DAS-14
Screenshots