Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to locate device by Vendor & Product ID, should Product name lookup fail #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dhorlick
Copy link

@dhorlick dhorlick commented Aug 27, 2024

On my Ubuntu 20.04 system, the Anker USB hub relays no product name for the Wii dongle, whatsoever:

% lsusb -v | less
⋮
Bus 003 Device 029: ID 1bad:3330 Harmonix Music USB2.1 Hub
Device Descriptor:
  bLength                18
  bDescriptorType         1
  bcdUSB               1.10
  bDeviceClass            0 
  bDeviceSubClass         0 
  bDeviceProtocol         0 
  bMaxPacketSize0         8
  idVendor           0x1bad Harmonix Music
  idProduct          0x3330 
  bcdDevice            0.05
  iManufacturer           1 
  iProduct                2

So the pull request tries to match by Vendor and Product ID, should the lookup by product name prove unsuccessful.

It also provides better error feedback, for troubleshooting.

@dhorlick dhorlick changed the title Attempt to locate device by Product ID, should Product name lookup fail Attempt to locate device by Vendor & Product ID, should Product name lookup fail Aug 31, 2024
Copy link
Collaborator

@KabooHahahein KabooHahahein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad we're still using rb3 keytars :D

@dhorlick
Copy link
Author

dhorlick commented Sep 1, 2024

I'm glad we're still using rb3 keytars :D

Rock on! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants