Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong condition #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix wrong condition #42

wants to merge 1 commit into from

Commits on Jun 9, 2022

  1. Fix wrong condition 

    The condition of the `FindBox` inner loop is wrong and allows `x` go beyond `itemsToPack[y].Quantity` iterations as soon as `Quantity > 1`. As a result, the analyzed box may be one of another box "type", and will be analyzed again later by following iterations of outer loop.

The empty item added in `Initialize` serves no purpose anymore since it just prevented OutOfRange exceptions caused by the wrong check discussed above.
    @psychopatt
    psychopatt authored Jun 9, 2022
    Configuration menu
    Copy the full SHA
    c815438 View commit details
    Browse the repository at this point in the history