Finally eliminate the +lib target.

davidgiven · Oct 19, 2024 · ed604f6 · ed604f6
1 parent 3c67a67
commit ed604f6
Show file tree

Hide file tree

Showing 19 changed files with 43 additions and 49 deletions.
diff --git a/build.py b/build.py
@@ -19,36 +19,6 @@
 
 clibrary(name="protocol", hdrs={"protocol.h": "./protocol.h"})
 
-cxxlibrary(
-    name="lib",
-    srcs=[
-        "./lib/readerwriter.cc",
-    ],
-    hdrs={
-        "lib/readerwriter.h": "./lib/readerwriter.h",
-    },
-    deps=[
-        "+fmt_lib",
-        "+protocol",
-        "dep/adflib",
-        "dep/fatfs",
-        "dep/hfsutils",
-        "dep/libusbp",
-        "dep/stb",
-        "src/formats",
-        "lib/core",
-        "lib/config",
-        "lib/data",
-        "lib/external",
-        "lib/fluxsink",
-        "lib/fluxsource",
-        "lib/imagereader",
-        "lib/imagewriter",
-        "lib/decoders",
-        "lib/encoders",
-    ],
-)
-
 corpustests = []
 if not glob("../fluxengine-testdata/data"):
     print("fluxengine-testdata not found; skipping corpus tests")

diff --git a/lib/algorithms/build.py b/lib/algorithms/build.py
@@ -0,0 +1,21 @@
+from build.c import cxxlibrary
+
+cxxlibrary(
+    name="algorithms",
+    srcs=["./readerwriter.cc"],
+    hdrs={
+        "lib/algorithms/readerwriter.h": "./readerwriter.h",
+    },
+    deps=[
+        "lib/core",
+        "lib/config",
+        "lib/data",
+        "lib/usb",
+        "lib/encoders",
+        "lib/decoders",
+        "lib/fluxsource",
+        "lib/fluxsink",
+        "lib/imagereader",
+        "lib/imagewriter",
+    ],
+)
diff --git a/lib/readerwriter.cc → lib/algorithms/readerwriter.cc b/lib/readerwriter.cc → lib/algorithms/readerwriter.cc
@@ -2,7 +2,7 @@
 #include "lib/config/config.h"
 #include "lib/config/flags.h"
 #include "lib/data/fluxmap.h"
-#include "lib/readerwriter.h"
+#include "lib/algorithms/readerwriter.h"
 #include "protocol.h"
 #include "lib/usb/usb.h"
 #include "lib/encoders/encoders.h"

diff --git a/lib/readerwriter.h → lib/algorithms/readerwriter.h b/lib/readerwriter.h → lib/algorithms/readerwriter.h
diff --git a/lib/vfs/build.py b/lib/vfs/build.py
@@ -46,9 +46,12 @@
         "lib/vfs/vfs.h": "./vfs.h",
     },
     deps=[
-        "+lib",
         "+fmt_lib",
         "arch",
+        "lib/algorithms",
         ".+proto_lib",
+        "dep/hfsutils",
+        "dep/adflib",
+        "dep/fatfs",
     ],
 )
diff --git a/lib/vfs/fluxsectorinterface.cc b/lib/vfs/fluxsectorinterface.cc
@@ -1,7 +1,7 @@
 #include "lib/core/globals.h"
 #include "lib/vfs/sectorinterface.h"
 #include "lib/data/image.h"
-#include "lib/readerwriter.h"
+#include "lib/algorithms/readerwriter.h"
 #include "lib/decoders/decoders.h"
 #include "lib/fluxsource/fluxsource.h"
 #include "lib/data/layout.h"

diff --git a/src/build.py b/src/build.py
@@ -31,7 +31,6 @@
     cflags=["-I."],
     deps=[
         "+fmt_lib",
-        "+lib",
         "+protobuf_lib",
         "+protocol",
         "+z_lib",
@@ -46,6 +45,7 @@
         "lib/data",
         "lib/external",
         "lib/vfs",
+        "lib/algorithms",
         "arch",
         "src/formats",
     ],

diff --git a/src/fe-putfile.cc b/src/fe-putfile.cc
@@ -3,7 +3,7 @@
 #include "lib/data/fluxmap.h"
 #include "lib/data/sector.h"
 #include "lib/config/proto.h"
-#include "lib/readerwriter.h"
+#include "lib/algorithms/readerwriter.h"
 #include "lib/imagereader/imagereader.h"
 #include "lib/imagewriter/imagewriter.h"
 #include "lib/fluxsource/fluxsource.h"

diff --git a/src/fe-rawread.cc b/src/fe-rawread.cc
@@ -1,7 +1,7 @@
 #include "lib/core/globals.h"
 #include "lib/config/config.h"
 #include "lib/config/flags.h"
-#include "lib/readerwriter.h"
+#include "lib/algorithms/readerwriter.h"
 #include "lib/data/fluxmap.h"
 #include "lib/decoders/decoders.h"
 #include "lib/data/sector.h"

diff --git a/src/fe-rawwrite.cc b/src/fe-rawwrite.cc
@@ -1,7 +1,7 @@
 #include "lib/core/globals.h"
 #include "lib/config/config.h"
 #include "lib/config/flags.h"
-#include "lib/readerwriter.h"
+#include "lib/algorithms/readerwriter.h"
 #include "lib/data/fluxmap.h"
 #include "lib/data/sector.h"
 #include "lib/config/proto.h"

diff --git a/src/fe-read.cc b/src/fe-read.cc
@@ -1,7 +1,7 @@
 #include "lib/core/globals.h"
 #include "lib/config/config.h"
 #include "lib/config/flags.h"
-#include "lib/readerwriter.h"
+#include "lib/algorithms/readerwriter.h"
 #include "lib/data/fluxmap.h"
 #include "lib/decoders/decoders.h"
 #include "lib/data/sector.h"

diff --git a/src/fe-write.cc b/src/fe-write.cc
@@ -1,7 +1,7 @@
 #include "lib/core/globals.h"
 #include "lib/config/config.h"
 #include "lib/config/flags.h"
-#include "lib/readerwriter.h"
+#include "lib/algorithms/readerwriter.h"
 #include "lib/data/fluxmap.h"
 #include "lib/decoders/decoders.h"
 #include "lib/encoders/encoders.h"

diff --git a/src/fileutils.cc b/src/fileutils.cc
@@ -4,7 +4,7 @@
 #include "lib/data/fluxmap.h"
 #include "lib/data/sector.h"
 #include "lib/config/proto.h"
-#include "lib/readerwriter.h"
+#include "lib/algorithms/readerwriter.h"
 #include "lib/fluxsource/fluxsource.h"
 #include "lib/fluxsink/fluxsink.h"
 #include "lib/imagereader/imagereader.h"

diff --git a/src/gui/build.py b/src/gui/build.py
@@ -63,7 +63,6 @@
         "dep/hfsutils",
         "dep/libusbp",
         "extras+icons",
-        "+lib",
         "lib/core",
         "lib/data",
         "lib/vfs",

diff --git a/src/gui/drivetypes/build.py b/src/gui/drivetypes/build.py
@@ -32,5 +32,5 @@
 cxxlibrary(
     name="drivetypes",
     srcs=[".+drivetypes_cc", ".+drivetypes_table_cc"],
-    deps=["+lib"],
+    deps=["lib/core", "lib/config"],
 )
diff --git a/src/gui/imagerpanel.cc b/src/gui/imagerpanel.cc
@@ -8,7 +8,7 @@
 #include "lib/encoders/encoders.h"
 #include "lib/decoders/decoders.h"
 #include "lib/config/proto.h"
-#include "lib/readerwriter.h"
+#include "lib/algorithms/readerwriter.h"
 #include "gui.h"
 #include "lib/data/layout.h"
 #include "fluxviewerwindow.h"

diff --git a/src/gui/mainwindow.cc b/src/gui/mainwindow.cc
@@ -3,7 +3,7 @@
 #include "lib/config/proto.h"
 #include "gui.h"
 #include "lib/core/logger.h"
-#include "lib/readerwriter.h"
+#include "lib/algorithms/readerwriter.h"
 #include "lib/fluxsource/fluxsource.h"
 #include "lib/fluxsink/fluxsink.h"
 #include "lib/imagereader/imagereader.h"

diff --git a/tests/build.py b/tests/build.py
@@ -54,7 +54,6 @@
                 deps=[
                     "lib/external+fl2_proto_lib",
                     "+fmt_lib",
-                    "+lib",
                     "+protobuf_lib",
                     "+protocol",
                     "+z_lib",
@@ -84,7 +83,6 @@
                 deps=[
                     "lib/external+fl2_proto_lib",
                     "+fmt_lib",
-                    "+lib",
                     "+protobuf_lib",
                     "+protocol",
                     "+z_lib",
@@ -96,6 +94,7 @@
                     "dep/libusbp",
                     "dep/snowhouse",
                     "dep/stb",
+                    "lib/algorithms",
                     "lib/config",
                     "lib/core",
                     "lib/data",

diff --git a/tools/build.py b/tools/build.py
@@ -10,13 +10,14 @@
     srcs=["./brother120tool.cc"],
     deps=[
         "+fmt_lib",
-        "+lib",
         "+protobuf_lib",
         "+z_lib",
         "lib/config",
         "lib/core",
         "lib/data",
         "lib/fluxsource+proto_lib",
+        "lib/algorithms",
+        "src/formats",
     ]
     + emu,
 )
@@ -26,13 +27,14 @@
     srcs=["./brother240tool.cc"],
     deps=[
         "+fmt_lib",
-        "+lib",
         "+protobuf_lib",
         "+z_lib",
         "lib/config",
         "lib/core",
         "lib/data",
         "lib/fluxsource+proto_lib",
+        "lib/algorithms",
+        "src/formats",
     ]
     + emu,
 )
@@ -42,7 +44,6 @@
     srcs=["./upgrade-flux-file.cc"],
     deps=[
         "+fmt_lib",
-        "+lib",
         "+protobuf_lib",
         "+protocol",
         "+sqlite3_lib",
@@ -53,6 +54,7 @@
         "lib/data",
         "lib/external+fl2_proto_lib",
         "lib/fluxsource+proto_lib",
+        "lib/algorithms",
         "src/formats",
     ],
 )