Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sonarqube integration #81

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Patschkowski
Copy link

@Patschkowski Patschkowski commented Dec 15, 2023

Added support for SonarQube so that one can generate the rules for SonarQube (one time action) as well as feed the analysis results into SonarQube, eg from a pipeline build with Jenkins

Felix Patschkowski added 3 commits December 16, 2023 07:26
…rules and reports so that they can be imported into SonarQube using the cxx plugin. Also removed some unnecessary spaces.

Signed-off-by: Felix Patschkowski <[email protected]>
Signed-off-by: Felix Patschkowski <[email protected]>
@Patschkowski Patschkowski force-pushed the add-sonarqube-integration branch from d672234 to be386c1 Compare December 16, 2023 06:27
@Patschkowski
Copy link
Author

@david-a-wheeler , please help reviewing and merging. Thank you

@david-a-wheeler
Copy link
Owner

Thanks so much!

A few lines have spaces just before the end-of-line, which can be a problem later on. I can fix that myself.

I need to verify that this works on both Python2 and Python3. The 2022 Python survey (the latest I found) reports that 29% of data analysis and 23% of devOps/ System admins / writing admin scripts use Python 2.

@Patschkowski
Copy link
Author

pylint output:

Your code has been rated at 9.55/10

test output (for python2 and python3):

'All tests pass!'

But I had to make the following modification on Windows

# The second condition I added to make the test pass but this is not caused by my code.
if os.name in ("windows", "nt", "dos") and len(list(map(glob.glob, args))) > 0:
  sys.argv[1:] = functools.reduce(operator.add,
                                          list(map(glob.glob, args)))
else:
  sys.argv[1:] = args

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants