Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Photoprism #543

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Photoprism #543

wants to merge 19 commits into from
+65 −0

Conversation

tsjordan-eng
Copy link

@tsjordan-eng tsjordan-eng commented Jul 10, 2022 •
edited
Loading

What this PR does / why we need it:
Adds PhotoPrism Photo management

@tsjordan-eng
Copy link
Author

I fixed the linting.

Do I need to put this in the roles format rather than the task format? I don't see a clear rule.

@davestephens
Copy link
Owner

Thanks for the contribution - yes - the code needs to be moved to a role please. The tasks-style additions are legacy and (mostly) now removed.

Also - please move the code unrelated to photoprism into a separate PR.

davestephens
davestephens requested changes Jul 21, 2022
View reviewed changes
tasks/photoprism.yml Outdated Show resolved Hide resolved
tasks/photoprism.yml Outdated Show resolved Hide resolved
tasks/photoprism.yml Outdated Show resolved Hide resolved
tasks/photoprism.yml Outdated Show resolved Hide resolved
tasks/photoprism.yml Outdated Show resolved Hide resolved
@tsjordan-eng
Copy link
Author

I moved it all to a role and removed my documentation changes to CONTRIBUTING.

@st0nedB
Copy link

st0nedB commented Oct 9, 2022

Hey, is something still missing in this PR? It seems complete. What are the plans for merging?

@tsjordan-eng
Copy link
Author

tsjordan-eng commented Oct 9, 2022 via email

@tsjordan-eng
Copy link
Author

I keep getting emails about actions failing. It looks like there are errors in drone-ci where a gitea variable is not available. Is this my problem to fix?

tsjordan-eng and others added 3 commits January 13, 2023 23:01
@tsjordan-eng
Try to fix drone CI gitea missing variable
83ca599 
From Github:

```
TASK [drone-ci : Add webhook allowed hosts to Gitea] ***************************
fatal: [instance]: FAILED! =>
The task includes an option with an undefined variable. The error was: 'gitea_data_directory' is undefined. 'gitea_data_directory' is undefined

The error appears to be in '/github/workspace/roles/drone-ci/tasks/main.yml': line 67, column 7, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

    - name: Add webhook allowed hosts to Gitea
      ^ here
```

I tried to find the nearest place these variables are supposed to be
defined for drone ci. We'll see how it goes.
@tsjordan-eng
Merge branch 'davestephens:master' into photoprism
dd00abc
@tsjordan-eng
Revert "Try to fix drone CI gitea missing variable"
562c5a9 
This reverts commit 83ca599.
@tsjordan-eng
Copy link
Author

@davestephens the requested changes have been made. This request is waiting on your approval.

tanc
tanc suggested changes Mar 14, 2023
View reviewed changes
roles/photoprism/tasks/main.yml Outdated Show resolved Hide resolved
This was referenced Jul 25, 2023
Closed
Open
@tsjordan-eng tsjordan-eng requested a review from tanc December 3, 2024 07:50
tanc
tanc approved these changes Dec 3, 2024
View reviewed changes
Copy link

@tanc tanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved away from Ansible Nas so can't test the changes but they look good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanc tanc tanc approved these changes

@davestephens davestephens Awaiting requested review from davestephens

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsjordan-eng @davestephens @st0nedB @tanc