Fixes for false positives in unused-components rule #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobocv
commented
Aug 16, 2024
•
lobocv
commented
- Recursively build reference maps in unused-components check
lobocv
force-pushed
the
unused-components-false-positives
branch
from
cb60f8e
to
223a306
Compare
|
This relies on pb33f/libopenapi#322 which is why the build is failing |
lobocv
force-pushed
the
unused-components-false-positives
branch
from
a0735cf
to
caaa08c
Compare
added 2 commits
September 10, 2024 08:42
…ctually set to the path, not just the filename - Include references from the root as well as the rolodex when checking unused components
lobocv
force-pushed
the
unused-components-false-positives
branch
from
caaa08c
to
440ff38
Compare
|
pb33f/libopenapi#322 was merged. |
lobocv
commented
Oct 11, 2024
lobocv
commented
Oct 11, 2024
|
@daveshanley Can we get this merged so it doesn't get stale? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.