ZDM-606: Support colon operator in fuzzy SAI queries #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-antoniak
requested review from
joao-r-reis,
alicel,
grighetto,
absurdfarce and
weideng1
as code owners
lukasz-antoniak
force-pushed
the
ZDM-606
branch
3 times, most recently
from
b7eac1d to
1eda3a3
Compare
joao-r-reis
reviewed
Jun 6, 2024
Comment on lines
+186
to
+191
| : K_WHERE relation ( logicalOperator relation )* | ||
| ; | ||
|
|
||
| logicalOperator | ||
| : K_AND | ||
| | K_OR |
There was a problem hiding this comment.
the changes on this file (the highlighted ones here and the lines 219 and 501 below) are basically the only changes to the production code right? just to make sure I'm not missing anything. The rest of the diff is just test code?
There was a problem hiding this comment.
And the one below with :. Production code changes were only for syntax definition.
|
Add a |
lukasz-antoniak
force-pushed
the
ZDM-606
branch
2 times, most recently
from
ff52e89 to
cca35a8
Compare
joao-r-reis
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link: https://datastax.jira.com/browse/ZDM-606