use monotonic time instead of system time for timers in the IoReactor #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents strange timeouts around leap seconds (if you're not using a splaying ntp server), and also allows you to use this driver along with tools like Timecop in testing, since Timecop manipulates
Timebut notMonotime.This adds a new dependency (https://github.com/Freaky/monotime), which has a minimum-supported Ruby version of 2.5. Given that everything before Ruby 2.7 is EOL already anyway, this seems okay, but there might be some value in changing the README for ruby-driver and the testing to reflect modern versions of Ruby. I could also switch to
hires, but I tend to use monotime for ergonomic reasons.