Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade style guide #157

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Upgrade style guide #157

merged 4 commits into from
Jan 6, 2025

Conversation

mendonk
Copy link
Contributor

@mendonk mendonk commented Dec 19, 2024 •
edited
Loading

Preview

This PR updates the Luna Streaming Upgrade to 3.1 page to conform more with the Google Developer Style Guide.

A follow-on PR in docs-infra redirects the page "migration.adoc" to this page, because that information is presented here.
Docs-infra redirect PR

@mendonk mendonk self-assigned this Dec 19, 2024
@plpesvc-ds
Copy link

plpesvc-ds commented Dec 19, 2024 •
edited
Loading

Build successful! ✅
Deploying draft.
Deploy successful! View draft

1 similar comment
@plpesvc-ds
Copy link

plpesvc-ds commented Dec 19, 2024 •
edited
Loading

Build successful! ✅
Deploying draft.
Deploy successful! View draft

@plpesvc-ds
Copy link

The draft build for this pull request has been cleaned up due to being stale.

Draft builds 2 weeks old or older were automatically removed.

You can rebuild the draft at any time by pushing a new commit to this pull request:

git checkout upgrade-style-guide
git commit --allow-empty -m 'rebuild draft'
git push origin upgrade-style-guide

@plpesvc-ds
Copy link

plpesvc-ds commented Jan 3, 2025 •
edited
Loading

Build successful! ✅
Deploying draft.
Deploy successful! View draft

@drchung5 drchung5 self-requested a review January 3, 2025 18:16
drchung5
drchung5 approved these changes Jan 3, 2025
View reviewed changes
Copy link

@drchung5 drchung5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mendonk mendonk merged commit b99ad57 into release/3.1_3.x Jan 6, 2025
1 check passed
@mendonk mendonk deleted the upgrade-style-guide branch January 6, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drchung5 drchung5 drchung5 approved these changes

Assignees

@mendonk mendonk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mendonk @plpesvc-ds @drchung5