Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASSJAVA-53: Upgrade Guava to 33.3.1-jre #12

Closed
wants to merge 1 commit into from

Conversation

lukasz-antoniak
Copy link
Collaborator

Update Guava to version 33.3.1. Replaces PE #11:

  • Uses newer version of Guava.
  • Update of Maven shaded plugin is necessary to be able to create shaded JAR (otherwise build process fails with below error).
Caused by: java.lang.IllegalArgumentException
    at org.objectweb.asm.ClassReader.<init> (Unknown Source)
    at org.objectweb.asm.ClassReader.<init> (Unknown Source)
    at org.objectweb.asm.ClassReader.<init> (Unknown Source)
    at org.apache.maven.plugins.shade.DefaultShader.addRemappedClass (DefaultShader.java:418)
    at org.apache.maven.plugins.shade.DefaultShader.shadeSingleJar (DefaultShader.java:220)
    at org.apache.maven.plugins.shade.DefaultShader.shadeJars (DefaultShader.java:181)
    at org.apache.maven.plugins.shade.DefaultShader.shade (DefaultShader.java:104)
    at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute (ShadeMojo.java:442)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)

@sbelnap
Copy link

sbelnap commented Jan 22, 2025

@olim7t @tolbertam @adutra @absurdfarce what are your thoughts on this pull request?

@absurdfarce
Copy link
Contributor

absurdfarce commented Jan 22, 2025

Hey @sbelnap, thanks for the question! As part of work on CASSJAVA-53 the contents of this project have been brought into the cassandra-java-driver repository and we now build the artifact directly there. The relevant PR can be found here.

Apologies, the above is the PR for upgrading Guava (after) we imported it. The actual PR to handle the import was done as part of CASSJAVA-52 and can be found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants