Fix dead link contributing #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmelton
requested changes
Jun 25, 2023
| @@ -2,6 +2,6 @@ | |||
| layout: redirected | |||
| sitemap: false | |||
| redirect_to: | |||
| - https://github.com/dataplat/dbatools/blob/development/contributing.md | |||
| - https://github.com/dataplat/dbatools/blob/master/CONTRIBUTING.md | |||
There was a problem hiding this comment.
Suggested change
| - https://github.com/dataplat/dbatools/blob/master/CONTRIBUTING.md | |
| - https://github.com/dataplat/dbatools/blob/development/CONTRIBUTING.md |
Please revert the branch reference
| @@ -235,7 +235,7 @@ <h1 class="entry-title">the path to 1.0</h1> | |||
| <p>As you may have noticed, we release a 0.9.x update with bug fixes and new features almost daily, so why haven’t we released 1.0 yet?</p> | |||
| <h2>Shifting from “a bag of functions” to a proper module</h2> | |||
| <p>We love new functionality, of course, but we must take a step back from new development and consolidate what we have in a properly usable module.</p> | |||
| <p>Most of the contributors are damn good SQL Server Pros, a few are damn good PowerShell programmers, with the majority of “casual” developers being able to successfully publish a new function in less than a week time. But what we aren’t so good at is advertising our needs. We recently updated our <a href="https://github.com/dataplat/dbatools/blob/master/contributing.md">contributing.md</a> to be more on par with the latest months of developing. Stay tuned there, as the few TODOs left are coming, but the path is mostly set.</p> | |||
| <p>Most of the contributors are damn good SQL Server Pros, a few are damn good PowerShell programmers, with the majority of “casual” developers being able to successfully publish a new function in less than a week time. But what we aren’t so good at is advertising our needs. We recently updated our <a href="https://github.com/dataplat/dbatools/blob/master/CONTRIBUTING.md">contributing.md</a> to be more on par with the latest months of developing. Stay tuned there, as the few TODOs left are coming, but the path is mostly set.</p> | |||
There was a problem hiding this comment.
Suggested change
| <p>Most of the contributors are damn good SQL Server Pros, a few are damn good PowerShell programmers, with the majority of “casual” developers being able to successfully publish a new function in less than a week time. But what we aren’t so good at is advertising our needs. We recently updated our <a href="https://github.com/dataplat/dbatools/blob/master/CONTRIBUTING.md">contributing.md</a> to be more on par with the latest months of developing. Stay tuned there, as the few TODOs left are coming, but the path is mostly set.</p> | |
| <p>Most of the contributors are damn good SQL Server Pros, a few are damn good PowerShell programmers, with the majority of “casual” developers being able to successfully publish a new function in less than a week time. But what we aren’t so good at is advertising our needs. We recently updated our <a href="https://github.com/dataplat/dbatools/blob/development/CONTRIBUTING.md">contributing.md</a> to be more on par with the latest months of developing. Stay tuned there, as the few TODOs left are coming, but the path is mostly set.</p> |
Please set the branch to this one to be development as well.
| @@ -2,6 +2,6 @@ | |||
| layout: redirected | |||
| sitemap: false | |||
| redirect_to: | |||
| - https://github.com/dataplat/dbatools/blob/prerelease/contributing.md#appveyor-setup | |||
| - https://github.com/dataplat/dbatools/blob/master/CONTRIBUTING.md#appveyor-setup | |||
There was a problem hiding this comment.
Suggested change
| - https://github.com/dataplat/dbatools/blob/master/CONTRIBUTING.md#appveyor-setup | |
| - https://github.com/dataplat/dbatools/blob/development/CONTRIBUTING.md#appveyor-setup |
Please set the branch reference to development branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed several dead contribution links.
Other solutions: rename the CONTRIBUTING.md file to contributing.md in the dbatools repository so that the existing links work: https://github.com/dataplat/dbatools/blob/master/CONTRIBUTING.md