This repository was archived by the owner on Apr 17, 2018. It is now read-only.
Closed
Conversation
The other datamapper gems depend mostly on multi_json 1.3.2 Example: https://github.com/datamapper/dm-serializer/blob/master/dm-serializer.gemspec
Member
|
After I merge this #86 can you rebase/squash and push this PR again so that it runs in CI (now that I enabled PR runs again)? |
Author
|
yes I can do that, I also relaxed the multi_json dependency on dm-serializer |
Member
|
Go for a rebase, I just merged the fix into master. Thanks @basex! |
Author
|
Sorry tpitale, there is not really a need to decrease this gem dm-types version required. The problem is with dm-serializer. I will rebase or create a new PR there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The other datamapper gems depend mostly on multi_json 1.3.2
Example: https://github.com/datamapper/dm-serializer/blob/master/dm-serializer.gemspec
dm-types also depended previously on 1.3.2 e541869