Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colors when using mounted colors and auto colors #176

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

artemipanchuk
Copy link
Contributor

No description provided.

@Flunt1k
Copy link
Contributor

Flunt1k commented Nov 7, 2023

As a suggestion: We already have a list of colors used (colorsConfig.mountedColors), it looks like we can avoid the first pass through the array and do the coloring in one pass through the graphs.
I suppose we could do something like Object.values(colorsConfig.mountedColors) and then add that to usedColors. After that, we can make a single pass through the graphs and color them

@artemipanchuk artemipanchuk merged commit 11145bb into main Nov 8, 2023
@artemipanchuk artemipanchuk deleted the apanchuk-CHARTS-8611 branch November 8, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants