E2e test for editor page

src/shared/constants/qa/editor.ts

@@ -1,3 +1,8 @@
+export const enum EditorPageQA {
+    RunButton = 'button-draw-preview',
+    SaveButton = 'save-entry-button',
+}
+
 export const enum EditorTemplatesQA {
     NoTemplate = 'editor-templates-no-template-item',
     Selector = 'editor-templates-selector-item',

src/ui/units/editor/components/ButtonDrawPreview/ButtonDrawPreview.js

@@ -5,6 +5,7 @@ import block from 'bem-cn-lite';
 import {i18n} from 'i18n';
 import PropTypes from 'prop-types';
 
+import {EditorPageQA} from '../../../../../shared';
 import {EVENT_DRAW_PREVIEW} from '../../constants/common';
 
 const b = block('btn-draw-preview');
@@ -35,7 +36,7 @@ function ButtonDrawPreview({onDrawPreview, className, disabled}) {
             size="m"
             onClick={() => onDrawPreview()}
             disabled={disabled}
-            qa="button-draw-preview"
+            qa={EditorPageQA.RunButton}
         >
             {i18n('editor.common.view', 'button_show-preview')}
         </Button>

src/ui/units/editor/components/ButtonSave/ButtonSave.js

@@ -17,6 +17,7 @@ import {
     sdk,
 } from 'ui';
 
+import {EditorPageQA} from '../../../../../shared';
 import {
     DIALOG_RESOLVE_STATUS,
     ENTRY_ACTION,
@@ -162,6 +163,7 @@ function ButtonSave({
         <div className={b()}>
             <NavigationPrompt when={!disabledSave} />
             <Button
+                qa={EditorPageQA.SaveButton}
                 view={getBtnSaveTheme()}
                 size="m"
                 disabled={disabledSave}

tests/page-objects/constants/common-selectors.ts

@@ -10,6 +10,7 @@ export const enum CommonSelectors {
 }
 
 export const enum DialogSelectors {
+    CloseDialogButton = '.g-dialog-btn-close__btn',
     ApplyButton = '.g-dialog-footer__button_action_apply',
 }
 

tests/page-objects/editor/EditorPage.ts

@@ -1,6 +1,7 @@
-import {slct} from '../../utils';
+import {deleteEntity, entryDialogFillAndSave, slct} from '../../utils';
 import {BasePage, BasePageProps} from '../BasePage';
 import ChartKit from '../wizard/ChartKit';
+import {EditorPageQA} from '../../../src/shared';
 
 interface EditorPageProps extends BasePageProps {}
 
@@ -18,7 +19,17 @@ class EditorPage extends BasePage {
     }
 
     async drawPreview() {
-        await this.page.click(slct('button-draw-preview'));
+        await this.page.click(slct(EditorPageQA.RunButton));
+    }
+
+    async saveChartEntry(entryName: string) {
+        await this.page.locator(slct(EditorPageQA.SaveButton)).click();
+
+        await entryDialogFillAndSave(this.page, entryName);
+    }
+
+    async deleteEntry() {
+        await deleteEntity(this.page);
     }
 }
 

tests/suites/editor/errorProxy.test.ts

@@ -2,12 +2,12 @@ import {Page} from '@playwright/test';
 
 import EditorPage from '../../page-objects/editor/EditorPage';
 import datalensTest from '../../utils/playwright/globalTestDefinition';
-import {openTestPage} from '../../utils';
+import {openTestPage, slct} from '../../utils';
 import {RobotChartsEditorUrls} from '../../utils/constants';
 import {DEFAULT_QUERY} from '../../page-objects/constants/base';
+import {EditorPageQA} from '../../../src/shared';
 
 const SELECTORS = {
-    RUN_BUTTON: '[data-qa=button-draw-preview]',
     CHARKIT_ERROR: '[data-qa=chartkit-error]',
 };
 
@@ -23,7 +23,7 @@ datalensTest.describe('ChartEditor passing JS errors to the user', () => {
         const editor = await page.waitForSelector('.view-line');
         await editor.click();
         await editor.type('Hello World!');
-        const runButton = await page.waitForSelector(SELECTORS.RUN_BUTTON);
+        const runButton = await page.waitForSelector(slct(EditorPageQA.RunButton));
         await runButton.click();
         const charkitError = await page.waitForSelector(SELECTORS.CHARKIT_ERROR);
         const errotTitle = await charkitError.waitForSelector('.datalens-chartkit-error__title');

tests/utils/constants.ts

@@ -6,7 +6,6 @@ export enum RobotChartsDatasets {
     SampleCHDataset = 'sample-csv-dataset',
     CitiesDataset = 'cities-dataset',
     SampleDsWithoutProfit = 'dataset-sample-without-profit',
-    BigDataset = 'big-dataset',
     ObligatoryFilterDataset = 'dataset-with-obligatory-filters-duplicate',
     DatasetWithParameters = 'sample-csv-dataset-with-parameters',
     OrderSalesDataset = 'order-sales-ds',
@@ -15,7 +14,6 @@ export enum RobotChartsDatasets {
 
 export enum RobotChartsWizardUrls {
     Empty = '/wizard/',
-    WizardWithParameterDataset = '/wizard/?__datasetId=ktrfwixwpwikc',
     WizardCitiesDataset = '/wizard/?__datasetId=uxyjsgrbam4sk',
     WizardForDatasetSampleCh = '/wizard/?__datasetId=bfvw78uczxp65',
     WizardForGeoDataset = '/wizard/?__datasetId=f9v6rrirbjjka',
@@ -65,6 +63,7 @@ export enum RobotChartsWizardUrls {
 export enum RobotChartsEditorUrls {
     EditorNew = '/editor/new',
     EditorEmptyDraft = '/editor/draft',
+    EditorNewTableFromTemplate = '/editor/draft/table',
     EditorWithWizardId = '/editor/ikblc7qjn4reb',
     EditorWithSQLId = '/editor/estm3g44u4g84',
     InputWithReset = '/editor/gx2pqz0oqtno6',