Fix gradient coloring of the table for zero values (#1623)

datalens-tech · Sep 30, 2024 · 7ac7f96 · 7ac7f96
1 parent 19399a0
commit 7ac7f96
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 1 deletion.
diff --git a/src/server/modes/charts/plugins/datalens/utils/color-helpers.ts b/src/server/modes/charts/plugins/datalens/utils/color-helpers.ts
@@ -127,7 +127,8 @@ function mapAndColorizeTableCells(rows: TableCellsRow[], colorsConfig: ChartColo
             if (typeof cell === 'object') {
                 const colorValue =
                     typeof cell.color !== 'number' || Number.isNaN(cell.color) ? null : cell.color;
-                const backgroundColor = colorValue ? gradientColors[colorValue] : undefined;
+                const backgroundColor =
+                    colorValue === null ? undefined : gradientColors[colorValue];
 
                 if (backgroundColor && !cell.css) {
                     cell.css = {

diff --git a/...ng.test.ts/Wizard-Flat-table-Gradient-coloring-for-zero-values-screenshot-1.png b/...ng.test.ts/Wizard-Flat-table-Gradient-coloring-for-zero-values-screenshot-1.png
diff --git a/tests/opensource-suites/wizard/visualizations/flat-table/coloring.test.ts b/tests/opensource-suites/wizard/visualizations/flat-table/coloring.test.ts
@@ -3,6 +3,7 @@ import {expect} from '@playwright/test';
 import {
     ChartKitQa,
     GradientType,
+    Operations,
     WizardPageQa,
     WizardVisualizationId,
 } from '../../../../../src/shared';
@@ -68,5 +69,30 @@ datalensTest.describe('Wizard', () => {
             await expect(chart).toBeVisible();
             await expect(chartContainer).toHaveScreenshot();
         });
+
+        datalensTest('Gradient coloring for zero values @screenshot', async ({page}) => {
+            const wizardPage = new WizardPage({page});
+            const chartContainer = page.locator(slct(WizardPageQa.SectionPreview));
+            const previewLoader = chartContainer.locator(slct(ChartKitQa.Loader));
+
+            await wizardPage.sectionVisualization.addFieldByClick(PlaceholderName.Filters, 'id');
+            await wizardPage.filterEditor.selectFilterOperation(Operations.LTE);
+            await wizardPage.filterEditor.setInputValue('2');
+            await wizardPage.filterEditor.apply();
+
+            await wizardPage.sectionVisualization.addFieldByClick(
+                PlaceholderName.FlatTableColumns,
+                'id',
+            );
+
+            await wizardPage.createNewFieldWithFormula('evenOrOdd', 'max([id]) % 2');
+            await wizardPage.sectionVisualization.addFieldByClick(
+                PlaceholderName.Colors,
+                'evenOrOdd',
+            );
+
+            await expect(previewLoader).not.toBeVisible();
+            await expect(chartContainer).toHaveScreenshot();
+        });
     });
 });