Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(miniconda): --run to run arbirary commands to possibly tune up that miniconda installation #209

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yarikoptic
Copy link
Member

This is at large to allow to address some issues which might come up with miniconda installations without waiting to hardcode the workarounds into datalad-installer. e.g. for

with current change we can address by adding --run 'conda install libarchive --solver=classic' ATM, i.e.

src/datalad_installer.py -E /tmp/mini1.env miniconda --path /tmp/mini1 --channel conda-forge --python-match minor --batch --run 'conda install libarchive --solver=classic' git-annex -m conda

Yet to decide but if to proceed this way, need to

  • add test

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 65.13%. Comparing base (d9e289a) to head (69f4fcc).

Files with missing lines Patch % Lines
src/datalad_installer.py 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
- Coverage   65.75%   65.13%   -0.63%     
==========================================
  Files           1        1              
  Lines        1647     1652       +5     
  Branches      284      286       +2     
==========================================
- Hits         1083     1076       -7     
- Misses        460      469       +9     
- Partials      104      107       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yarikoptic added a commit that referenced this pull request Nov 7, 2024
ref: #206

#209 seems could provide a workaround
but I think we should test/workaround within datalad-installer without requiring adjustment
of each similar invocation
yarikoptic added a commit that referenced this pull request Nov 7, 2024
ref: #206

#209 seems could provide a workaround
but I think we should test/workaround within datalad-installer without requiring adjustment
of each similar invocation
yarikoptic added a commit that referenced this pull request Nov 7, 2024
ref: #206

#209 seems could provide a workaround
but I think we should test/workaround within datalad-installer without requiring adjustment
of each similar invocation
yarikoptic added a commit that referenced this pull request Nov 7, 2024
ref: #206

#209 seems could provide a workaround
but I think we should test/workaround within datalad-installer without requiring adjustment
of each similar invocation
@yarikoptic
Copy link
Member Author

for #206 decided to proceed with

unless there would be a usecase for this added feature, let's just keep it in draft here for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants