Skip to content

Conversation

@xyuzh
Copy link
Contributor

@xyuzh xyuzh commented Jan 16, 2026

Description

This PR updates the Ray Data API usage in the RayBTSMinhashDeduplicator to use the current recommended parameter.

Changes

  • Replaced the deprecated concurrency parameter with compute parameter in the ray.data.Dataset.map_batches() call

Reason

According to the Ray Data API documentation, the concurrency parameter is deprecated and should be replaced with the compute parameter for specifying the compute strategy.

Testing

  • The functionality remains the same, just using the updated API parameter name
  • ray.data.ActorPoolStrategy(size=concurrency) is now passed via compute instead of concurrency

Replace the deprecated 'concurrency' parameter with 'compute' parameter
in ray.data.Dataset.map_batches() call according to Ray Data API
documentation. The 'concurrency' parameter was deprecated in favor of
'compute' for specifying the compute strategy.

Reference: https://docs.ray.io/en/latest/data/api/doc/ray.data.Dataset.map_batches.html
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @xyuzh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Ray Data API usage within the RayBTSMinhashDeduplicator to align with current best practices. The primary goal is to replace a deprecated parameter in the map_batches function, ensuring the codebase remains up-to-date and compatible with future versions of the Ray framework. The functionality of the deduplicator remains unchanged, as this is purely an API parameter name update.

Highlights

  • Ray Data API Update: Replaced the deprecated 'concurrency' parameter with the 'compute' parameter in the ray.data.Dataset.map_batches() call within the RayBTSMinhashDeduplicator.
  • API Compliance: This change ensures compliance with the latest Ray Data API documentation, which recommends using 'compute' for specifying the compute strategy.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the Ray Data API usage by replacing the deprecated concurrency parameter with the compute parameter in the map_batches call. The change is consistent with the latest Ray documentation and is applied to the correct location in the code. This is a good and necessary update to keep the codebase current with its dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants