-
Notifications
You must be signed in to change notification settings - Fork 318
fix: replace deprecated 'concurrency' with 'compute' in map_batches call #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Replace the deprecated 'concurrency' parameter with 'compute' parameter in ray.data.Dataset.map_batches() call according to Ray Data API documentation. The 'concurrency' parameter was deprecated in favor of 'compute' for specifying the compute strategy. Reference: https://docs.ray.io/en/latest/data/api/doc/ray.data.Dataset.map_batches.html
Summary of ChangesHello @xyuzh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Ray Data API usage within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the Ray Data API usage by replacing the deprecated concurrency parameter with the compute parameter in the map_batches call. The change is consistent with the latest Ray documentation and is applied to the correct location in the code. This is a good and necessary update to keep the codebase current with its dependencies.
Description
This PR updates the Ray Data API usage in the RayBTSMinhashDeduplicator to use the current recommended parameter.
Changes
concurrencyparameter withcomputeparameter in theray.data.Dataset.map_batches()callReason
According to the Ray Data API documentation, the
concurrencyparameter is deprecated and should be replaced with thecomputeparameter for specifying the compute strategy.Testing
ray.data.ActorPoolStrategy(size=concurrency)is now passed viacomputeinstead ofconcurrency