Add user meaning plugin #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Feb 3, 2020
|
|
||
| # We read the addresses from the input dataset | ||
| # And write the coordinates in the output dataset | ||
| input_name = get_input_names_for_role('input')[0] |
There was a problem hiding this comment.
this is a bit of a nitpick (and doesn't seem to be done elsewhere in codebase), but it might be a good idea to switch key strings to variables. Although, I guess this is all only important depending on how parameter keys to a plugin are versioned. Anyways, just a suggestion but feel free to ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very common pattern is to map constant values to a more significant meaning.
This plugin allows to define a JSON that gives the mapping for multiple columns in one iteration.