Library: text extraction #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3032c97.
gaelleguillou
approved these changes
Jan 5, 2026
Collaborator
gaelleguillou
left a comment
gaelleguillou
left a comment
There was a problem hiding this comment.
Looks good overall!
Some non urgent remarks (discussed previously) :
- Should we find a way to kill the pre-commit or limit it to the library so we can use it selectively? Currently it makes it hard to test the code when reviewing it
- Should we look into better archival processes than that "old" folder?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add scraping code for obtaining full text from the library and extracting results and conclusions sections.
Also adds old scraping code from other branches in
oldfolder, just to have it somewhere for potential future use (don't bother reviewing that folder).