Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing actions #454

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add missing actions #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89e50ca
Add missing actions
godofdream Jun 14, 2024
0bfb45c
Extend tests for missing Actions
godofdream Jun 17, 2024
2e68470
Fix Tests naming
godofdream Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/services/security/resource_privilege_application.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func ResourceSecurityPrivilegeApplication() *schema.Resource {
Required: true,
Elem: &schema.Schema{
Type: schema.TypeString,
ValidateFunc: validation.StringInSlice([]string{"ADD", "READ", "EDIT", "DELETE"}, false),
ValidateFunc: validation.StringInSlice([]string{"ADD", "READ", "EDIT", "DELETE", "STOP", "DISASSOCIATE", "ASSOCIATE", "START", "ALL"}, false),
},
},
},
Expand Down
7 changes: 6 additions & 1 deletion internal/services/security/resource_privilege_application_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func TestAccResourceSecurityPrivilegeApplication(t *testing.T) {
privilege := security.PrivilegeApplication{
Name: acctest.RandString(20),
Description: acctest.RandString(20),
Actions: []security.SecurityPrivilegeApplicationActions{"ADD", "READ", "EDIT", "DELETE"},
Actions: []security.SecurityPrivilegeApplicationActions{"ADD", "READ", "EDIT", "DELETE", "STOP", "DISASSOCIATE", "ASSOCIATE", "START", "ALL"},
Domain: acctest.RandString(20),
}

Expand All @@ -35,6 +35,11 @@ func TestAccResourceSecurityPrivilegeApplication(t *testing.T) {
resource.TestCheckResourceAttr(resName, "actions.1", string(privilege.Actions[1])),
resource.TestCheckResourceAttr(resName, "actions.2", string(privilege.Actions[2])),
resource.TestCheckResourceAttr(resName, "actions.3", string(privilege.Actions[3])),
resource.TestCheckResourceAttr(resName, "actions.4", string(privilege.Actions[4])),
resource.TestCheckResourceAttr(resName, "actions.5", string(privilege.Actions[5])),
resource.TestCheckResourceAttr(resName, "actions.6", string(privilege.Actions[6])),
resource.TestCheckResourceAttr(resName, "actions.7", string(privilege.Actions[7])),
resource.TestCheckResourceAttr(resName, "actions.8", string(privilege.Actions[8])),
),
},
},
Expand Down
2 changes: 1 addition & 1 deletion internal/services/security/resource_privilege_repository_admin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func ResourceSecurityPrivilegeRepositoryAdmin() *schema.Resource {
Required: true,
Elem: &schema.Schema{
Type: schema.TypeString,
ValidateFunc: validation.StringInSlice([]string{"ADD", "READ", "DELETE", "BROWSE", "EDIT"}, false),
ValidateFunc: validation.StringInSlice([]string{"ADD", "READ", "DELETE", "BROWSE", "EDIT", "ALL"}, false),
},
},
},
Expand Down
3 changes: 2 additions & 1 deletion internal/services/security/resource_privilege_repository_admin_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func TestAccResourceSecurityPrivilegeRepositoryAdmin(t *testing.T) {
privilege := security.PrivilegeRepositoryAdmin{
Name: acctest.RandString(20),
Description: acctest.RandString(20),
Actions: []security.SecurityPrivilegeRepositoryAdminActions{"ADD", "READ", "DELETE", "BROWSE", "EDIT"},
Actions: []security.SecurityPrivilegeRepositoryAdminActions{"ADD", "READ", "DELETE", "BROWSE", "EDIT", "ALL"},
Repository: acctest.RandString(20),
Format: "helm",
}
Expand All @@ -37,6 +37,7 @@ func TestAccResourceSecurityPrivilegeRepositoryAdmin(t *testing.T) {
resource.TestCheckResourceAttr(resName, "actions.2", string(privilege.Actions[2])),
resource.TestCheckResourceAttr(resName, "actions.3", string(privilege.Actions[3])),
resource.TestCheckResourceAttr(resName, "actions.4", string(privilege.Actions[4])),
resource.TestCheckResourceAttr(resName, "actions.5", string(privilege.Actions[5])),
),
},
},
Expand Down
2 changes: 1 addition & 1 deletion internal/services/security/resource_privilege_repository_content_selector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func ResourceSecurityPrivilegeRepositoryContentSelector() *schema.Resource {
Required: true,
Elem: &schema.Schema{
Type: schema.TypeString,
ValidateFunc: validation.StringInSlice([]string{"ADD", "READ", "DELETE", "BROWSE", "EDIT"}, false),
ValidateFunc: validation.StringInSlice([]string{"ADD", "READ", "DELETE", "BROWSE", "EDIT", "ALL"}, false),
},
},
},
Expand Down
3 changes: 2 additions & 1 deletion internal/services/security/resource_privilege_repository_content_selector_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func TestAccResourceSecurityPrivilegeRepositoryContentSelector(t *testing.T) {
privilege := security.PrivilegeRepositoryContentSelector{
Name: acctest.RandString(20),
Description: acctest.RandString(20),
Actions: []security.SecurityPrivilegeRepositoryContentSelectorActions{"ADD", "READ", "DELETE", "BROWSE", "EDIT"},
Actions: []security.SecurityPrivilegeRepositoryContentSelectorActions{"ADD", "READ", "DELETE", "BROWSE", "EDIT", "ALL"},
Repository: acctest.RandString(20),
Format: "helm",
ContentSelector: acctest.RandString(20),
Expand All @@ -39,6 +39,7 @@ func TestAccResourceSecurityPrivilegeRepositoryContentSelector(t *testing.T) {
resource.TestCheckResourceAttr(resName, "actions.2", string(privilege.Actions[2])),
resource.TestCheckResourceAttr(resName, "actions.3", string(privilege.Actions[3])),
resource.TestCheckResourceAttr(resName, "actions.4", string(privilege.Actions[4])),
resource.TestCheckResourceAttr(resName, "actions.5", string(privilege.Actions[5])),
),
},
},
Expand Down
2 changes: 1 addition & 1 deletion internal/services/security/resource_privilege_repository_view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func ResourceSecurityPrivilegeRepositoryView() *schema.Resource {
Required: true,
Elem: &schema.Schema{
Type: schema.TypeString,
ValidateFunc: validation.StringInSlice([]string{"ADD", "READ", "DELETE", "BROWSE", "EDIT"}, false),
ValidateFunc: validation.StringInSlice([]string{"ADD", "READ", "DELETE", "BROWSE", "EDIT", "ALL"}, false),
},
},
},
Expand Down
3 changes: 2 additions & 1 deletion internal/services/security/resource_privilege_repository_view_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func TestAccResourceSecurityPrivilegeRepositoryView(t *testing.T) {
privilege := security.PrivilegeRepositoryView{
Name: acctest.RandString(20),
Description: acctest.RandString(20),
Actions: []security.SecurityPrivilegeRepositoryViewActions{"ADD", "READ", "DELETE", "BROWSE", "EDIT"},
Actions: []security.SecurityPrivilegeRepositoryViewActions{"ADD", "READ", "DELETE", "BROWSE", "EDIT", "ALL"},
Repository: acctest.RandString(20),
Format: "helm",
}
Expand All @@ -37,6 +37,7 @@ func TestAccResourceSecurityPrivilegeRepositoryView(t *testing.T) {
resource.TestCheckResourceAttr(resName, "actions.2", string(privilege.Actions[2])),
resource.TestCheckResourceAttr(resName, "actions.3", string(privilege.Actions[3])),
resource.TestCheckResourceAttr(resName, "actions.4", string(privilege.Actions[4])),
resource.TestCheckResourceAttr(resName, "actions.5", string(privilege.Actions[5])),
),
},
},
Expand Down
2 changes: 1 addition & 1 deletion internal/services/security/resource_privilege_script.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func ResourceSecurityPrivilegeScript() *schema.Resource {
Required: true,
Elem: &schema.Schema{
Type: schema.TypeString,
ValidateFunc: validation.StringInSlice([]string{"ADD", "READ", "DELETE", "RUN", "BROWSE", "EDIT"}, false),
ValidateFunc: validation.StringInSlice([]string{"ADD", "READ", "DELETE", "RUN", "BROWSE", "EDIT", "ALL"}, false),
},
},
},
Expand Down
3 changes: 2 additions & 1 deletion internal/services/security/resource_privilege_script_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func TestAccResourceSecurityPrivilegeScript(t *testing.T) {
privilege := security.PrivilegeScript{
Name: acctest.RandString(20),
Description: acctest.RandString(20),
Actions: []security.SecurityPrivilegeScriptActions{"ADD", "READ", "DELETE", "RUN", "BROWSE", "EDIT"},
Actions: []security.SecurityPrivilegeScriptActions{"ADD", "READ", "DELETE", "RUN", "BROWSE", "EDIT", "ALL"},
ScriptName: acctest.RandString(20),
}
resource.Test(t, resource.TestCase{
Expand All @@ -36,6 +36,7 @@ func TestAccResourceSecurityPrivilegeScript(t *testing.T) {
resource.TestCheckResourceAttr(resName, "actions.3", string(privilege.Actions[3])),
resource.TestCheckResourceAttr(resName, "actions.4", string(privilege.Actions[4])),
resource.TestCheckResourceAttr(resName, "actions.5", string(privilege.Actions[5])),
resource.TestCheckResourceAttr(resName, "actions.6", string(privilege.Actions[6])),
),
},
},
Expand Down
Loading