Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Episode 7 updates for line sizes and other #463

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

jonjab
Copy link
Contributor

@jonjab jonjab commented Jan 21, 2025

Closes #462 and others issues that were confusing / out of date in episode 7. primarily the deprecation of size = ( replaced with linewidth = )

See the comments in #462. This PR also takes care of the maintainer list.

Copy link

github-actions bot commented Jan 21, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/r-raster-vector-geospatial/compare/md-outputs..md-outputs-PR-463

The following changes were observed in the rendered markdown documents:

 07-vector-shapefile-attributes-in-r.md             |  37 +++++++++++----------
 ...tributes-in-r-rendered-add-legend-to-plot-1.png | Bin 29113 -> 30989 bytes
 ...es-in-r-rendered-colored-state-boundaries-1.png | Bin 31675 -> 40002 bytes
 ...tributes-in-r-rendered-harv-boardwalk-map-1.png | Bin 11597 -> 12178 bytes
 ...ibutes-in-r-rendered-harv-path-line-types-1.png | Bin 13879 -> 14722 bytes
 ...utes-in-r-rendered-harv-paths-bike-horses-1.png | Bin 26155 -> 26726 bytes
 ...ributes-in-r-rendered-harv-stone-wall-map-1.png | Bin 22459 -> 23843 bytes
 ...tributes-in-r-rendered-modify-legend-plot-1.png | Bin 29436 -> 31363 bytes
 ...butes-in-r-rendered-plot-different-colors-1.png | Bin 29497 -> 31360 bytes
 ...dered-plot-subset-shapefile-unique-colors-1.png | Bin 25138 -> 26804 bytes
 index.md                                           |  12 ++-----
 md5sum.txt                                         |   4 +--
 12 files changed, 23 insertions(+), 30 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-01-21 22:25:32 +0000

github-actions bot pushed a commit that referenced this pull request Jan 21, 2025
@jonjab
Copy link
Contributor Author

jonjab commented Jan 21, 2025

These were fairly minor edits that resolved a number of issues. While it's bad form to accept my own pull, I'm gong to do it.

@jonjab jonjab merged commit 19d908b into datacarpentry:main Jan 21, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 21, 2025
Auto-generated via `{sandpaper}`
Source  : 19d908b
Branch  : main
Author  : Jon Jablonski <[email protected]>
Time    : 2025-01-21 22:30:30 +0000
Message : Merge pull request #463 from jonjab/main

Episode 7 updates for line sizes and other
github-actions bot pushed a commit that referenced this pull request Jan 21, 2025
Auto-generated via `{sandpaper}`
Source  : 6ab6b31
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-21 22:32:11 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 19d908b
Branch  : main
Author  : Jon Jablonski <[email protected]>
Time    : 2025-01-21 22:30:30 +0000
Message : Merge pull request #463 from jonjab/main

Episode 7 updates for line sizes and other
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mistake in challenge in Lesson 7
1 participant