Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 07-vector-shapefile-attributes-in-r.Rmd #449

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

rfbrown
Copy link
Contributor

@rfbrown rfbrown commented Jun 24, 2024

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

Update element_rect(size = 1) to element_rect(line_width = 1) to address warning: The size argument of element_rect() is deprecated as of ggplot2 3.4.0. ℹ Please use the linewidth argument instead.

Update element_rect(size) to element_rect(line_width) to address warning: The `size` argument of `element_rect()` is deprecated as of ggplot2 3.4.0.
ℹ Please use the `linewidth` argument instead.
Copy link

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

@rfbrown
Copy link
Contributor Author

rfbrown commented Jun 24, 2024

We note that the warning also shows up in the lesson and can be used as an example (which we did on the fly)- but if used as an example, the lesson should contain descriptive text about the warning.

Note that there are a few other places in the lesson where this issue shows up, so the fix should be consistent. We suggest changing all mentions of element_rect(size = ) to element_rect(linewidth = ).

@jonjab jonjab merged commit bd05e08 into datacarpentry:main Nov 23, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Nov 23, 2024
Auto-generated via `{sandpaper}`
Source  : bd05e08
Branch  : main
Author  : Jon Jablonski <[email protected]>
Time    : 2024-11-23 19:14:54 +0000
Message : Merge pull request #449 from rfbrown/patch-2

Update 07-vector-shapefile-attributes-in-r.Rmd
github-actions bot pushed a commit that referenced this pull request Nov 23, 2024
Auto-generated via `{sandpaper}`
Source  : c8f0f00
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-11-23 19:16:29 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : bd05e08
Branch  : main
Author  : Jon Jablonski <[email protected]>
Time    : 2024-11-23 19:14:54 +0000
Message : Merge pull request #449 from rfbrown/patch-2

Update 07-vector-shapefile-attributes-in-r.Rmd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants