Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update join types in pandas merge function #584

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

quist00
Copy link
Contributor

@quist00 quist00 commented Jan 30, 2024

Closes #583

Expanded description of cross join with suggestions and added self-joins with a resource for users to explore that further on their own time if they need that approach. Joins is already a relatively heavy subject for learners to grapple with so opted not to have full pedagogical sections covering these additional join types in detail.

Copy link

github-actions bot commented Jan 30, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/python-ecology-lesson/compare/md-outputs..md-outputs-PR-584

The following changes were observed in the rendered markdown documents:

 05-merging-data.md | 12 ++++++++----
 md5sum.txt         |  2 +-
 2 files changed, 9 insertions(+), 5 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-01-30 23:14:27 +0000

github-actions bot pushed a commit that referenced this pull request Jan 30, 2024
@quist00
Copy link
Contributor Author

quist00 commented Jan 30, 2024

@sheraaronhurt assuming I understand this comment correctly "Submitted on behalf of trainee for checkout," is there github username or other identifier for that learner we can include in the comment stream for reference purposes?

@sheraaronhurt
Copy link

@quist00 Here is the information requested: rmr969

@quist00 quist00 merged commit 64fb4bf into main Feb 5, 2024
3 checks passed
@quist00 quist00 deleted the improveExpandJoinsDiscussion branch February 5, 2024 16:28
github-actions bot pushed a commit that referenced this pull request Feb 5, 2024
Auto-generated via {sandpaper}
Source  : 64fb4bf
Branch  : main
Author  : David Palmquist <[email protected]>
Time    : 2024-02-05 16:28:33 +0000
Message : Merge pull request #584 from datacarpentry/improveExpandJoinsDiscussion

Update join types in pandas merge function
github-actions bot pushed a commit that referenced this pull request Feb 5, 2024
Auto-generated via {sandpaper}
Source  : 525e60e
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-02-05 16:29:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 64fb4bf
Branch  : main
Author  : David Palmquist <[email protected]>
Time    : 2024-02-05 16:28:33 +0000
Message : Merge pull request #584 from datacarpentry/improveExpandJoinsDiscussion

Update join types in pandas merge function
github-actions bot pushed a commit that referenced this pull request Feb 6, 2024
Auto-generated via {sandpaper}
Source  : 525e60e
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-02-05 16:29:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 64fb4bf
Branch  : main
Author  : David Palmquist <[email protected]>
Time    : 2024-02-05 16:28:33 +0000
Message : Merge pull request #584 from datacarpentry/improveExpandJoinsDiscussion

Update join types in pandas merge function
github-actions bot pushed a commit that referenced this pull request Feb 13, 2024
Auto-generated via {sandpaper}
Source  : 525e60e
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-02-05 16:29:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 64fb4bf
Branch  : main
Author  : David Palmquist <[email protected]>
Time    : 2024-02-05 16:28:33 +0000
Message : Merge pull request #584 from datacarpentry/improveExpandJoinsDiscussion

Update join types in pandas merge function
github-actions bot pushed a commit that referenced this pull request Feb 20, 2024
Auto-generated via {sandpaper}
Source  : 525e60e
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-02-05 16:29:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 64fb4bf
Branch  : main
Author  : David Palmquist <[email protected]>
Time    : 2024-02-05 16:28:33 +0000
Message : Merge pull request #584 from datacarpentry/improveExpandJoinsDiscussion

Update join types in pandas merge function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

describe better joins
2 participants